Bug 20758

Summary: refactor CSSStyleSelector transform code
Product: WebKit Reporter: Dean Jackson <dino>
Component: CSSAssignee: Dean Jackson <dino>
Status: RESOLVED WONTFIX    
Severity: Normal CC: simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on: 20770, 20771    
Bug Blocks:    
Attachments:
Description Flags
refactoring patch
none
updated with changelog none

Dean Jackson
Reported 2008-09-09 19:13:58 PDT
CSSStyleSelector has a huge ugly chunk of code in the switch statement. Move that to a new function.
Attachments
refactoring patch (14.11 KB, patch)
2008-09-09 19:20 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
updated with changelog (14.59 KB, patch)
2008-09-10 15:48 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2008-09-09 19:20:15 PDT
Created attachment 23311 [details] refactoring patch needs tests for transforms!!
Dean Jackson
Comment 2 2008-09-10 15:27:58 PDT
Adding dependency to 20771 which has transform tests
Dean Jackson
Comment 3 2008-09-10 15:48:33 PDT
Created attachment 23332 [details] updated with changelog
Dean Jackson
Comment 4 2008-09-10 15:51:03 PDT
Tested with the new tests in 20771
Dean Jackson
Comment 5 2008-09-10 16:03:27 PDT
Looks like 20770 does this as well.
Dean Jackson
Comment 6 2008-09-11 15:39:51 PDT
This is fixed in 20770
Note You need to log in before you can comment on or make changes to this bug.