Bug 207524

Summary: AX: Unable to build webkit open source - build errors related to AXClientType
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jbedard, mark.lam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
patch
none
patch none

Description chris fleizach 2020-02-10 17:17:32 PST
./accessibility/AXObjectCache.cpp:395:9: error: use of undeclared identifier '_AXUIElementUseSecondaryAXThread'
        _AXUIElementUseSecondaryAXThread(true);
        ^
./accessibility/AXObjectCache.cpp:722:5: error: unknown type name 'AXClientType'
    AXClientType type = _AXGetClientForCurrentRequestUntrusted();
    ^
./accessibility/AXObjectCache.cpp:722:25: error: use of undeclared identifier '_AXGetClientForCurrentRequestUntrusted'
    AXClientType type = _AXGetClientForCurrentRequestUntrusted();
                        ^
./accessibility/AXObjectCache.cpp:724:20: error: use of undeclared identifier 'kAXClientTypeVoiceOver'
    return type == kAXClientTypeVoiceOver
                   ^
./accessibility/AXObjectCache.cpp:725:20: error: use of undeclared identifier 'kAXClientTypeUnknown'; did you mean
      'kCGContextTypeUnknown'?
        || type == kAXClientTypeUnknown;
                   ^~~~~~~~~~~~~~~~~~~~
                   kCGContextTypeUnknown
In file included from /Users/alexei/Desktop/wk-2-7-pm/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource68.cpp:1:
In file included from ./accessibility/AXObjectCache.cpp:107:
In file included from PAL/pal/spi/mac/HIServicesSPI.h:28:
PAL/pal/spi/cg/CoreGraphicsSPI.h:76:5: note: 'kCGContextTypeUnknown' declared here
    kCGContextTypeUnknown,
    ^
In file included from /Users/alexei/Desktop/wk-2-7-pm/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource68.cpp:1:
./accessibility/AXObjectCache.cpp:756:9: error: use of undeclared identifier '_AXUIElementUseSecondaryAXThread'
        _AXUIElementUseSecondaryAXThread(true);
        ^
6 errors generated.
Comment 1 chris fleizach 2020-02-10 17:17:42 PST
<rdar://problem/59279722>
Comment 2 chris fleizach 2020-02-10 17:18:43 PST
Created attachment 390322 [details]
patch
Comment 3 chris fleizach 2020-02-10 17:23:11 PST
Created attachment 390323 [details]
patch
Comment 4 chris fleizach 2020-02-10 17:25:34 PST
Created attachment 390325 [details]
patch
Comment 5 Mark Lam 2020-02-10 17:33:21 PST
Comment on attachment 390325 [details]
patch

rs=me if EWS bots are green.
Comment 6 WebKit Commit Bot 2020-02-11 00:11:04 PST
Comment on attachment 390325 [details]
patch

Clearing flags on attachment: 390325

Committed r256294: <https://trac.webkit.org/changeset/256294>
Comment 7 WebKit Commit Bot 2020-02-11 00:11:05 PST
All reviewed patches have been landed.  Closing bug.