Bug 207480

Summary: REGRESSION ( r254044 ): [ Win ] css1/box_properties/padding_left.html is failing
Product: WebKit Reporter: Truitt Savell <tsavell>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, koivisto, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=205762
Attachments:
Description Flags
patch none

Description Truitt Savell 2020-02-10 10:41:51 PST 
css1/box_properties/padding_left.html

This test is failing on windows. It began between r254044-254042

History:
https://results.webkit.org/?suite=layout-tests&test=css1%2Fbox_properties%2Fpadding_left.html&platform=win

Diff:
--- /home/buildbot/worker/win10-release-tests/build/layout-test-results/css1/box_properties/padding_left-expected.txt
+++ /home/buildbot/worker/win10-release-tests/build/layout-test-results/css1/box_properties/padding_left-actual.txt
@@ -9,11 +9,17 @@
       RenderBlock {PRE} at (0,34) size 769x90
         RenderText {#text} at (0,0) size 416x90
           text run at (0,0) width 400: ".zero {background-color: silver; padding-left: 0;}"
+          text run at (400,0) width 0: " "
           text run at (0,15) width 408: ".one {padding-left: 0.5in; background-color: aqua;}"
+          text run at (408,15) width 0: " "
           text run at (0,30) width 400: ".two {padding-left: 25px; background-color: aqua;}"
+          text run at (400,30) width 0: " "
           text run at (0,45) width 408: ".three {padding-left: 5em; background-color: aqua;}"
+          text run at (408,45) width 0: " "
           text run at (0,60) width 400: ".four {padding-left: 25%; background-color: aqua;}"
+          text run at (400,60) width 0: " "
           text run at (0,75) width 416: ".five {padding-left: -20px; background-color: aqua;}"
+          text run at (416,75) width 0: " "
       RenderBlock {HR} at (0,137) size 769x2 [border: (1px inset #000000)]
       RenderBlock {P} at (0,155) size 769x18 [bgcolor=#C0C0C0]
         RenderText {#text} at (0,0) size 203x18
Comment 1 Radar WebKit Bug Importer 2020-02-10 10:42:12 PST 
<rdar://problem/59316463>
Comment 2 Truitt Savell 2020-02-10 10:50:33 PST 
marked test as failing on https://trac.webkit.org/changeset/256195/webkit
Comment 3 Ryan Haddad 2020-02-10 11:42:12 PST 
It looks like the test was rebaselined for macOS here:
https://trac.webkit.org/changeset/254044/webkit#file176

Perhaps we just need to land a new baseline for Windows, too.
Comment 4 Antti Koivisto 2020-02-10 11:44:02 PST 
Yeah, this needs rebaseline
Comment 5 Antti Koivisto 2020-02-10 14:08:01 PST 
Created attachment 390295 [details]
patch
Comment 6 WebKit Commit Bot 2020-02-10 15:14:43 PST 
Comment on attachment 390295 [details]
patch

Clearing flags on attachment: 390295

Committed r256222: <https://trac.webkit.org/changeset/256222>
Comment 7 WebKit Commit Bot 2020-02-10 15:14:45 PST 
All reviewed patches have been landed.  Closing bug.