Bug 207415

Summary: Harden HashTable IPC decoders
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, dbates, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch cdumez: review+

Alex Christensen
Reported 2020-02-07 16:07:15 PST
Harden HashTable IPC decoders
Attachments
Patch (2.18 KB, patch)
2020-02-07 16:07 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (3.33 KB, patch)
2020-02-07 16:15 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (3.60 KB, patch)
2020-02-07 16:23 PST, Alex Christensen 		cdumez: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-02-07 16:07:44 PST
Created attachment 390142 [details] Patch
Alex Christensen
Comment 2 2020-02-07 16:15:04 PST
Created attachment 390144 [details] Patch
Chris Dumez
Comment 3 2020-02-07 16:23:53 PST
Comment on attachment 390144 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390144&action=review > Source/WebKit/Platform/IPC/ArgumentCoders.h:392 > + if (UNLIKELY(!HashMapType::isValidValue(*key) || !hashMap.add(WTFMove(*key), WTFMove(*value)).isNewEntry)) { I thought it was isValidKey() for HashMap and isValidValue() for HashSet? > Source/WebKit/Platform/IPC/ArgumentCoders.h:447 > + if (UNLIKELY(!HashSetType::isValidKey(*key) || !hashSet.add(WTFMove(*key)).isNewEntry)) { ditto.
Alex Christensen
Comment 4 2020-02-07 16:23:56 PST
Created attachment 390145 [details] Patch
Chris Dumez
Comment 5 2020-02-07 16:25:35 PST
Comment on attachment 390145 [details] Patch r=me
Alex Christensen
Comment 6 2020-02-07 16:44:16 PST
http://trac.webkit.org/r256081
Radar WebKit Bug Importer
Comment 7 2020-02-07 16:45:26 PST
<rdar://problem/59278838>
Note You need to log in before you can comment on or make changes to this bug.