Summary: | [iOS] Check if PIP is supported in the UI process | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||||||
Component: | WebKit Misc. | Assignee: | Per Arne Vollan <pvollan> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, peng.liu6, philipj, sergio, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Per Arne Vollan
2020-02-07 14:07:20 PST
Created attachment 390123 [details]
Patch
Created attachment 390133 [details]
Patch
Comment on attachment 390133 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390133&action=review > Source/WebCore/testing/Internals.cpp:5472 > +#if PLATFORM(IOS_FAMILY) We need to check the support for Mac as well. (In reply to Peng Liu from comment #3) > Comment on attachment 390133 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=390133&action=review > > > Source/WebCore/testing/Internals.cpp:5472 > > +#if PLATFORM(IOS_FAMILY) > > We need to check the support for Mac as well. I will include that. Thanks for reviewing! Created attachment 390264 [details]
Patch
Comment on attachment 390264 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390264&action=review Looks good. r=me > Source/WebCore/ChangeLog:11 > + WebContent is storing the received value. We have PIP in macOS, but I guess we don't do this check there? Are there macOS changes we should plan as well? (In reply to Brent Fulgham from comment #6) > Comment on attachment 390264 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=390264&action=review > > Looks good. r=me > > > Source/WebCore/ChangeLog:11 > > + WebContent is storing the received value. > > We have PIP in macOS, but I guess we don't do this check there? > > Are there macOS changes we should plan as well? Yes, you are right. There is some additional macOS work required, since macOS does not have the same setting/notification. Thanks for reviewing! (In reply to Per Arne Vollan from comment #7) > (In reply to Brent Fulgham from comment #6) > > Comment on attachment 390264 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=390264&action=review > > > > Looks good. r=me > > > > > Source/WebCore/ChangeLog:11 > > > + WebContent is storing the received value. > > > > We have PIP in macOS, but I guess we don't do this check there? > > > > Are there macOS changes we should plan as well? > > Yes, you are right. There is some additional macOS work required, since > macOS does not have the same setting/notification. > Sorry, I was thinking of another issue when making this comment. On macOS, we probably don't connect to the same service when checking whether PiP is enabled, but as you suggest, we should look into the issue on macOS as well, in order to determine which service is being used there. The commit-queue encountered the following flaky tests while processing attachment 390264 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 390264 [details] Patch Clearing flags on attachment: 390264 Committed r256531: <https://trac.webkit.org/changeset/256531> All reviewed patches have been landed. Closing bug. |