| Summary: | Do not process RTC Network messages coming from NetworkProcess if LibWebRTCNetwork is not active | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, darin, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
youenn fablet
2020-02-07 00:54:50 PST
Created attachment 390064 [details]
Patch
Created attachment 390070 [details]
Patch
Comment on attachment 390070 [details] Patch Rejecting attachment 390070 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 390070, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=390070&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=207376&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 390070 from bug 207376. Fetching: https://bugs.webkit.org/attachment.cgi?id=390070 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Eric Carlson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 3 diffs from patch file(s). patching file Source/WebKit/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp Hunk #1 FAILED at 110. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp.rej patching file Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetwork.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Eric Carlson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/13337568 Created attachment 393135 [details]
Patch for landing
Comment on attachment 393135 [details] Patch for landing Clearing flags on attachment: 393135 Committed r258200: <https://trac.webkit.org/changeset/258200> All reviewed patches have been landed. Closing bug. Comment on attachment 390070 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390070&action=review > Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp:113 > + auto& libWebRTCNetwork = WebProcess::singleton().libWebRTCNetwork(); I’d have named the local variable just "network" since it’s unambiguous in this local scope. Reopening to attach new patch. Created attachment 396396 [details]
Patch
(In reply to Darin Adler from comment #8) > Comment on attachment 390070 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=390070&action=review > > > Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp:113 > > + auto& libWebRTCNetwork = WebProcess::singleton().libWebRTCNetwork(); > > I’d have named the local variable just "network" since it’s unambiguous in > this local scope. Changed in landing patch. Committed r260068: <https://trac.webkit.org/changeset/260068> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396396 [details]. |