Summary: | ResourceLoadStatisticsDatabaseStore::dumpResourceLoadStatistics relies on the order of m_getAllDomainsStatement, which can be changed by HashTable's implementation | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, darin, mark.lam, webkit-bug-importer, wilander | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Yusuke Suzuki
2020-02-06 12:51:04 PST
Created attachment 389983 [details]
Patch
Comment on attachment 389983 [details]
Patch
r=me. Is the test already expecting sorted order? If not, you should rebase the test results also.
(In reply to Mark Lam from comment #2) > Comment on attachment 389983 [details] > Patch > > r=me. Is the test already expecting sorted order? If not, you should > rebase the test results also. Yes, luckily :) The commit-queue encountered the following flaky tests while processing attachment 389983 [details]: imported/w3c/web-platform-tests/web-animations/timing-model/timelines/update-and-send-events-replacement.html bug 207335 (author: graouts@apple.com) The commit-queue is continuing to process your patch. The commit-queue encountered the following flaky tests while processing attachment 389983 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 389983 [details] Patch Clearing flags on attachment: 389983 Committed r256002: <https://trac.webkit.org/changeset/256002> All reviewed patches have been landed. Closing bug. |