Summary: | Mandate UUID version 4 for mDNS ICE candidates | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||
Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | achristensen, benjamin, cdumez, cmarcelo, commit-queue, darin, dbates, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
youenn fablet
2020-02-06 06:03:49 PST
Created attachment 389944 [details]
Patch
Created attachment 389950 [details]
Patch
Comment on attachment 389950 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389950&action=review > Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:306 > static String extractIPAddres(const String& sdp) s/extractIPAddres/extractIPAddress/ (In reply to Eric Carlson from comment #4) > Comment on attachment 389950 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=389950&action=review > > > Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:306 > > static String extractIPAddres(const String& sdp) > > s/extractIPAddres/extractIPAddress/ Will fix it. Created attachment 390059 [details]
Patch for landing
The commit-queue encountered the following flaky tests while processing attachment 390059 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 390059 [details] Patch for landing Clearing flags on attachment: 390059 Committed r256016: <https://trac.webkit.org/changeset/256016> All reviewed patches have been landed. Closing bug. Comment on attachment 390059 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=390059&action=review > Source/WTF/wtf/UUID.cpp:84 > +static inline bool isHexadecimalCharacter(UChar character) Should use isASCIIHexDigit from <wtf/ASCIICType.h> rather than writing a new one. Reopening to attach new patch. Created attachment 390078 [details]
Fix according comments
The commit-queue encountered the following flaky tests while processing attachment 390078 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 390078 [details] Fix according comments Clearing flags on attachment: 390078 Committed r256030: <https://trac.webkit.org/changeset/256030> All reviewed patches have been landed. Closing bug. |