Bug 207309 – [Cairo] Do not use old-style GNU field initializers

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Adrian Perez]

Clang is already warning about using 

  struct foo value = { member: 42 };

instead the standard syntax for field initializers should be used:

  struct foo value = { .member = 42 };

Log of warnings generated by Clang follows.

---

../Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:120:9: warning: use of GNU old-style field designator extension [-Wgnu-designator]                 
        x: cx + (r * cos(angleStart)),                                                                                                                         
        ^~                                                                                                                                                     
        .x =                                                                                                                                                   
../Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:121:9: warning: use of GNU old-style field designator extension [-Wgnu-designator]                 
        y: cy + (r * sin(angleStart))                                                                                                                          
        ^~                                                                                                                                                     
        .y =                                                                                                                                                   
../Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:124:9: warning: use of GNU old-style field designator extension [-Wgnu-designator]                 
        x: cx + (r * cos(angleStart)) - f * (r * sin(angleStart)),                                                                                             
        ^~                                                                                                                                                     
        .x =                                                                                                                                                   
../Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:125:9: warning: use of GNU old-style field designator extension [-Wgnu-designator]                 
        y: cy + (r * sin(angleStart)) + f * (r * cos(angleStart))                                                                                              
        ^~                                                                                                                                                     
        .y =                                                                                                                                                   
../Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:128:9: warning: use of GNU old-style field designator extension [-Wgnu-designator]                 
        x: cx + (r * cos(angleEnd)) + f * (r * sin(angleEnd)),                                                                                                 
        ^~                                                                                                                                                     
        .x =                                                                                                                                                   
../Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:129:9: warning: use of GNU old-style field designator extension [-Wgnu-designator]                 
        y: cy + (r * sin(angleEnd)) - f * (r * cos(angleEnd))                                                                                                  
        ^~                                                                                                                                                     
        .y =                                                                   
../Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:132:9: warning: use of GNU old-style field designator extension [-Wgnu-designator]                 
        x: cx + (r * cos(angleEnd)),
        ^~                                                                                                                                                     
        .x =                                                                                                                                                   
../Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:133:9: warning: use of GNU old-style field designator extension [-Wgnu-designator]                 
        y: cy + (r * sin(angleEnd))                                                                                                                            
        ^~       
        .y = 
8 warnings generated.

[Adrian Perez]

Created attachment 389899 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 389899 [details]
Patch

Clearing flags on attachment: 389899

Committed r255911: <https://trac.webkit.org/changeset/255911>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/59216924>