Summary: | REGRESSION: [ macOS wk1 ] ASSERTION FAILED: _notifications.contains(notificationID) imported/w3c/web-platform-tests/notifications/constructor-basic.html is flaky crashing | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jacob Uphoff <jacob_uphoff> | ||||||||||||
Component: | New Bugs | Assignee: | Chris Dumez <cdumez> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | aakash_jain, achristensen, beidson, cdumez, commit-queue, ggaren, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=207237 | ||||||||||||||
Attachments: |
|
Description
Jacob Uphoff
2020-02-05 16:20:30 PST
Created attachment 389989 [details]
Update Test Expectations
Comment on attachment 389989 [details] Update Test Expectations Clearing flags on attachment: 389989 Committed r255977: <https://trac.webkit.org/changeset/255977> Created attachment 393775 [details]
Test
Test to reproduce the issue now that back/forward cache is disabled by default in DRT.
Created attachment 393783 [details]
Patch
Comment on attachment 393783 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393783&action=review > Tools/DumpRenderTree/mac/MockWebNotificationProvider.mm:147 > + auto notification = _notifications.take(_notifications.begin()->key); This unnecessarily rehashes a lot. Why don't we just iterate then clear? Created attachment 393787 [details]
Patch
Can you please verify if http/wpt/notifications/constructor-basic-bfcache.html failure on windows is due to your patch. -PASS Called the notification constructor with one argument. +FAIL Called the notification constructor with one argument. Can't find variable: Notification Created attachment 393805 [details]
Patch
Committed r258613: <https://trac.webkit.org/changeset/258613> All reviewed patches have been landed. Closing bug and clearing flags on attachment 393805 [details]. http/wpt/notifications/constructor-basic-bfcache.html is consistently failing on iOS bots: https://build.webkit.org/results/Apple%20iOS%2013%20Simulator%20Release%20WK2%20(Tests)/r258630%20(3191)/results.html (In reply to Ryan Haddad from comment #11) > http/wpt/notifications/constructor-basic-bfcache.html is consistently > failing on iOS bots: > https://build.webkit.org/results/ > Apple%20iOS%2013%20Simulator%20Release%20WK2%20(Tests)/r258630%20(3191)/ > results.html Notifications are apparently meant to be skipped on iOS: LayoutTests/platform/ios/TestExpectations:http/tests/notifications We need to skip http/wpt/notifications too on this platform test. (In reply to Chris Dumez from comment #12) > Notifications are apparently meant to be skipped on iOS: > LayoutTests/platform/ios/TestExpectations:http/tests/notifications > > We need to skip http/wpt/notifications too on this platform test. https://trac.webkit.org/changeset/258668/webkit |