Bug 207303

Summary: ASSERTION FAILED: !needsLayout() [ macOS wk2 ] loader/stateobjects/pushstate-size-iframe.html is flaky crashing
Product: WebKit Reporter: Jacob Uphoff <jacob_uphoff>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=127916
https://bugs.webkit.org/show_bug.cgi?id=229820
Attachments:
Description Flags
Update Test Expectations none

Description Jacob Uphoff 2020-02-05 15:35:51 PST
loader/stateobjects/pushstate-size-iframe.html

This test has been crashing for all visible history on Catalina debug

I ran the test 200x in iterations and did not reproduce the failure. The test takes about 20 seconds per, so high iteration runs will take some time to do.

History:

https://results.webkit.org/?suite=layout-tests&test=loader%2Fstateobjects%2Fpushstate-size-iframe.html&limit=50000

Crash:

No crash log found for com.apple.WebKit.WebContent.Development:16600.

stdout:

stderr:
ASSERTION FAILED: !needsLayout()
./rendering/RenderView.cpp(306) : virtual void WebCore::RenderView::paint(WebCore::PaintInfo &, const WebCore::LayoutPoint &)
1   0x34fa87759 WTFCrash
2   0x33416841b WTFCrashWithInfo(int, char const*, char const*, int)
3   0x33821651b WebCore::RenderView::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
4   0x3380b12f2 WebCore::RenderLayer::paintBackgroundForFragments(WTF::Vector<WebCore::LayerFragment, 1ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WebCore::GraphicsContext&, WebCore::GraphicsContext&, WebCore::LayoutRect const&, bool, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::RenderObject*)
5   0x3380add60 WebCore::RenderLayer::paintLayerContents(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>)
6   0x3380cdc3c WebCore::RenderLayerBacking::paintIntoLayer(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::IntRect const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::EventRegionContext*)::$_10::operator()(WebCore::RenderLayer&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) const
7   0x3380cd555 WebCore::RenderLayerBacking::paintIntoLayer(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::IntRect const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::EventRegionContext*)
8   0x3380cede2 WebCore::RenderLayerBacking::paintContents(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int)
9   0x337b09f90 WebCore::GraphicsLayer::paintGraphicsLayerContents(WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int)
10  0x337b9378d WebCore::GraphicsLayerCA::platformCALayerPaintContents(WebCore::PlatformCALayer*, WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int)
11  0x33589a831 WebCore::PlatformCALayer::drawLayerContents(WebCore::GraphicsContext&, WebCore::PlatformCALayer*, WTF::Vector<WebCore::FloatRect, 5ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&, unsigned int)
12  0x337bb247e WebCore::TileGrid::platformCALayerPaintContents(WebCore::PlatformCALayer*, WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int)
13  0x335a7a996 -[WebSimpleLayer drawInContext:]
14  0x7fff3c741d34 CABackingStoreUpdate_
15  0x7fff3c7a1985 invocation function for block in CA::Layer::display_()
16  0x7fff3c741242 -[CALayer _display]
17  0x335a7a77b -[WebSimpleLayer display]
18  0x7fff3c7402c3 CA::Layer::display_if_needed(CA::Transaction*)
19  0x7fff3c71eba6 CA::Context::commit_transaction(CA::Transaction*, double)
20  0x7fff3c71d7ce CA::Transaction::commit()
21  0x7fff2e27cba7 __62+[CATransaction(NSCATransaction) NS_setFlushesWithDisplayLink]_block_invoke
22  0x7fff2e99865d ___NSRunLoopObserverCreateWithHandler_block_invoke
23  0x7fff30f170ee __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__
24  0x7fff30f17014 __CFRunLoopDoObservers
25  0x7fff30f1670b __CFRunLoopRun
26  0x7fff30f15bd3 CFRunLoopRunSpecific
27  0x7fff335b91a8 -[NSRunLoop(NSRunLoop) runMode:beforeDate:]
28  0x7fff3366cd8b -[NSRunLoop(NSRunLoop) run]
29  0x7fff6880a0e1 _xpc_objc_main.cold.4
30  0x7fff6880a027 _xpc_objc_main
31  0x7fff68809b5a _xpc_copy_xpcservice_dictionary
LEAK: 2 WebPageProxy
Comment 1 Radar WebKit Bug Importer 2020-02-05 15:36:16 PST
<rdar://problem/59205224>
Comment 2 Jacob Uphoff 2020-02-05 15:41:14 PST
Created attachment 389888 [details]
Update Test Expectations
Comment 3 Truitt Savell 2020-02-05 15:43:32 PST
Comment on attachment 389888 [details]
Update Test Expectations

Clearing flags on attachment: 389888

Committed r255866: <https://trac.webkit.org/changeset/255866>