[Qt] Canvas gradients don't work as expected

• Component: WebKit Qt
• Status: RESOLVED FIXED

[Dirk Schulze]

Radial gradients are broken on Qt. Center and focal point are mixed up and the radius of the start circle is not supported by Qt.

[Dirk Schulze]

Created attachment 23266 [details]
Qt radial gradients

fixed radial gradients on Qt

[Dirk Schulze]

Created attachment 23314 [details]
Qt gradients

reused old canvas-code to get multiple color-stops with the same offset to work:
http://developer.mozilla.org/samples/canvas-tutorial/4_9_canvas_lineargradient.html

and added the code above to support the inner radius as well as the outer radius on Canvas:
http://developer.mozilla.org/samples/canvas-tutorial/4_10_canvas_radialgradient.html

-> gradients fixed

[Simon Hausmann]

Comment on attachment 23314 [details]
Qt gradients

Looks good, but there's a small coding style nitpick:

If (qFuzzyCompare(...)) {
   one line of code
} else
   another line of code

There's no need for braces in one-liners

[Dirk Schulze]

Created attachment 23326 [details]
Qt gradients

deleted braces :-)

[Simon Hausmann]

Comment on attachment 23326 [details]
Qt gradients

Thanks!

[Simon Hausmann]

Landed in r36330