Bug 207198

Summary: Implement the remote RenderingBackend
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: CanvasAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, annulen, beidson, cdumez, commit-queue, dino, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, glenn, graouts, gyuyoung.kim, hta, jer.noble, jsbell, kondapallykalyan, mkwst, mmaxfield, noam, pdr, philipj, ryuan.choi, schenney, sergio, simon.fraser, thorton, tommyw, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 207134    
Bug Blocks: 204955, 207233    
Attachments:
Description Flags
Patch
none
Patch for review
none
Patch
none
Patch
none
Fix internal bots none

Said Abou-Hallawa
Reported 2020-02-04 07:35:52 PST
RemoteRenderingBackend and RemoteRenderingBackendProxy will be responsible of creating the remote ImageBuffer objects. RemoteRenderingBackend will create the remote ImageBuffer in WebProcess while RemoteRenderingBackendProxy will create the associated remote ImageBuffer proxy in the GPUProcess. RemoteRenderingBackend will be created by WebChromeClient and owned by Chrome. ImageBuffer::create will have access to it through the HostWindow argument. All types of ImageBuffer will be created by RemoteRenderingBackend::createImageBuffer() method. In-process ImageBuffer types will be created by RenderingBackend:: createImageBuffer(). RemoteRenderingBackendProxy will be created and owned by GPUConnectionToWebProcess. RemoteRenderingBackend and RemoteRenderingBackendProxy will communicate with each other using IPC and a new ObjectIdentifier called RenderingBackendIdentifier.
Attachments
Patch (446.86 KB, patch)
2020-02-04 08:08 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch for review (61.38 KB, patch)
2020-02-04 10:55 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (70.56 KB, patch)
2020-02-26 16:19 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (70.59 KB, patch)
2020-02-26 16:39 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Fix internal bots (2.04 KB, patch)
2020-02-27 13:47 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2020-02-04 08:08:54 PST
Created attachment 389661 [details] Patch
Said Abou-Hallawa
Comment 2 2020-02-04 10:55:26 PST
Created attachment 389679 [details] Patch for review
Said Abou-Hallawa
Comment 3 2020-02-25 17:51:29 PST
After making HostWindow be the creator of the remote ImageBuffer, there is no need for this bug. *** This bug has been marked as a duplicate of bug 207134 ***
Said Abou-Hallawa
Comment 4 2020-02-26 16:00:33 PST
Will implement the RemoteRenderingBack because we do not what every RemoteImageBuffer to be a message sender or receiver.
Said Abou-Hallawa
Comment 5 2020-02-26 16:19:17 PST
Created attachment 391802 [details] Patch
Said Abou-Hallawa
Comment 6 2020-02-26 16:39:01 PST
Created attachment 391806 [details] Patch
Simon Fraser (smfr)
Comment 7 2020-02-26 16:49:44 PST
Comment on attachment 391806 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391806&action=review > Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h:65 > + IPC::MessageReceiverMap& messageReceiverMap() { return m_messageReceiverMap; } const?
Chris Dumez
Comment 8 2020-02-26 16:52:57 PST
Comment on attachment 391806 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391806&action=review >> Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h:65 >> + IPC::MessageReceiverMap& messageReceiverMap() { return m_messageReceiverMap; } > > const? IPC::MessageReceiverMap& messageReceiverMap() or const IPC::MessageReceiverMap& messageReceiverMap() const or both but not: IPC::MessageReceiverMap& messageReceiverMap() const { return m_messageReceiverMap; } please :)
WebKit Commit Bot
Comment 9 2020-02-26 17:52:02 PST
Comment on attachment 391806 [details] Patch Clearing flags on attachment: 391806 Committed r257542: <https://trac.webkit.org/changeset/257542>
WebKit Commit Bot
Comment 10 2020-02-26 17:52:05 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2020-02-26 17:53:19 PST
<rdar://problem/59830213>
Said Abou-Hallawa
Comment 12 2020-02-27 13:44:36 PST
This patch broke the internal build bots. The break is happening because of unified sources.
Said Abou-Hallawa
Comment 13 2020-02-27 13:47:42 PST
Created attachment 391907 [details] Fix internal bots
Ryan Haddad
Comment 14 2020-02-27 13:50:49 PST
Comment on attachment 391907 [details] Fix internal bots Clearing flags on attachment: 391907 Committed r257583: <https://trac.webkit.org/changeset/257583>
Ryan Haddad
Comment 15 2020-02-27 13:50:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.