Bug 207181
| Summary: | Commit queue should never set Author to itself for someone with an svn account | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | aakash_jain, ap, graouts, graouts, simon.fraser, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Simon Fraser (smfr)
We still have many examples of commits with Author:commit-queue@webkit.org from people who have valid svn accounts, for example:
https://trac.webkit.org/changeset/255552/webkit
https://trac.webkit.org/changeset/254659/webkit
It makes git log harder to parse, and committer affiliation harder to determine. Commit queue needs to fail when committing such patches if it can't correctly set the author.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Simon Fraser (smfr)
https://trac.webkit.org/changeset/254541/webkit
Radar WebKit Bug Importer
<rdar://problem/59137472>
Alexey Proskuryakov
> https://trac.webkit.org/changeset/255552/webkit
Antoine's Bugzilla and SVN accounts are different, and since post-commit hook doesn't consult contributors.json, it doesn't know that the Bugzilla user has an active SVN account. This is fixable in code, bit not trivially. Or he could rename his Bugzilla account to match.
> https://trac.webkit.org/changeset/254659/webkit
Same for Alex.
> https://trac.webkit.org/changeset/254541/webkit
Said doesn't have an active SVN account at this time.
> Commit queue needs to fail when committing such patches if it can't correctly set the author.
The author isn't set by commit queue, but by a post commit hook. Commit queue doesn't know about SVN accounts, and the hook doesn't know about contributors.json. We will need a new mechanism for communication between them, but even then I don't see how failing to commit is preferable.
Antoine Quint
So if I logged into bugs.webkit.org as graouts@webkit.org, all would be well/
Simon Fraser (smfr)
This seems to have regressed at some point, or people change local config and it breaks. Both Antoine and Said have successfully committed with the correct author before:
aced10ef9ab graouts@webkit.org Mon Oct 28 08:08:59 2019 +0000 [Web Animations] getKeyframes() doesn't return the right timing function for declarative animations https://bugs.webkit.org/show_bug.cgi?id=203475
7ae4c3115b5 said@apple.com Sat Nov 2 00:14:40 2019 +0000 SVG pair properties must be detached from their owner before it's deleted https://bugs.webkit.org/show_bug.cgi?id=203545
Alexey Proskuryakov
Replied privately.
> aced10ef9ab graouts@webkit.org Mon Oct 28 08:08:59 2019 +0000 [Web Animations] getKeyframes() doesn't return the right timing function for declarative animations https://bugs.webkit.org/show_bug.cgi?id=203475
This particular one was landed manually.
Antoine Quint
I just used the commit-queue to land https://trac.webkit.org/changeset/255953 and I was logged into Radar as graouts@apple.com, which is the email address configured locally with Git on the machine I authored the patch. The resulting commit is still not showing my email address.
Antoine Quint
https://trac.webkit.org/changeset/256017/webkit was landed via the commit-queue and I had logged into bugs.webkit.org as graouts@webkit.org when using `webkit-patch upload` and I had set my git user email to graouts@webkit.org. I'm not sure what is the decisive factor here, but there's no trace of the commit-queue in this commit.
Simon Fraser (smfr)
https://trac.webkit.org/changeset/255577/webkit