Bug 207173

Summary: Defer ending AppSSO sheets til NSWindowDidDeminiaturize or NSApplicationDidUnhide
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebKit Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for Landing
none
Patch none

Jiewen Tan
Reported 2020-02-03 18:03:43 PST
Defer ending AppSSO sheets til NSWindowDidDeminiaturize or NSApplicationDidUnhide.
Attachments
Patch (14.38 KB, patch)
2020-02-03 18:16 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch (14.46 KB, patch)
2020-02-03 22:31 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch for Landing (19.15 KB, patch)
2020-02-04 16:07 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch (19.22 KB, patch)
2020-02-04 16:16 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jiewen Tan
Comment 1 2020-02-03 18:03:59 PST
<rdar://problem/55669065>
Jiewen Tan
Comment 2 2020-02-03 18:16:00 PST
Created attachment 389611 [details] Patch
Jiewen Tan
Comment 3 2020-02-03 18:21:13 PST
Just realized this has a dependency on Bug 207079. Will upload a rebased patch once Bug 207079 is landed.
Jiewen Tan
Comment 4 2020-02-03 22:31:10 PST
Created attachment 389631 [details] Patch
Brent Fulgham
Comment 5 2020-02-04 12:41:36 PST
Comment on attachment 389631 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389631&action=review r=me > Source/WebKit/ChangeLog:14 > + or NSApplicationDidUnhide is received. What happens if the application is exited? Is everything cleaned up properly with these deferred observers? (I assume so).
Jiewen Tan
Comment 6 2020-02-04 15:52:53 PST
Comment on attachment 389631 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389631&action=review Thanks Brent for r+ this patch. >> Source/WebKit/ChangeLog:14 >> + or NSApplicationDidUnhide is received. > > What happens if the application is exited? Is everything cleaned up properly with these deferred observers? (I assume so). Yes, the notification center is bound to the app. However, you do remind me to examine what happens if the session is destroyed during miniaturization/hiding. I have made some changes to address that.
Jiewen Tan
Comment 7 2020-02-04 16:07:29 PST
Created attachment 389730 [details] Patch for Landing
Jiewen Tan
Comment 8 2020-02-04 16:16:39 PST
Created attachment 389733 [details] Patch
Jiewen Tan
Comment 9 2020-02-05 14:01:31 PST
Comment on attachment 389733 [details] Patch The api-ios bot is taking forever. cq+ regardless.
WebKit Commit Bot
Comment 10 2020-02-05 14:49:50 PST
Comment on attachment 389733 [details] Patch Clearing flags on attachment: 389733 Committed r255862: <https://trac.webkit.org/changeset/255862>
WebKit Commit Bot
Comment 11 2020-02-05 14:49:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.