Summary: | [iOS] Deny mach lookup to 'com.apple.webinspector' in the WebContent process. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||||
Component: | WebKit2 | Assignee: | Brent Fulgham <bfulgham> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, pvollan, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 203214 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Brent Fulgham
2020-02-03 17:39:14 PST
Created attachment 394018 [details]
Patch
Comment on attachment 394018 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394018&action=review R=me. > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:-641 > -;; Remote Web Inspector > -(allow mach-lookup > - (global-name "com.apple.webinspector")) > - I don't believe we can remove it on macOS just yet. Comment on attachment 394018 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394018&action=review >> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:-641 >> - > > I don't believe we can remove it on macOS just yet. Really? The connection seems to be vended on macOS, too. What's missing? Comment on attachment 394018 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394018&action=review >>> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:-641 >>> - >> >> I don't believe we can remove it on macOS just yet. > > Really? The connection seems to be vended on macOS, too. What's missing? The code is enabled for macOS, but the method WebProcessProxy::enableRemoteInspectorIfNeeded() checks a preference which only exist on iOS, I believe. Created attachment 394648 [details]
Patch for landing
Committed r259072: <https://trac.webkit.org/changeset/259072> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394648 [details]. |