Bug 207158

Summary: [bmalloc] Add declspec support for export macros
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: bmallocAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, commit-queue, ews-watchlist, ggaren, gyuyoung.kim, keith_miller, mark.lam, ryuan.choi, saam, sergio, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
ysuzuki: review+
Patch none

Don Olmstead
Reported 2020-02-03 15:32:24 PST
Currently just assuming *nix style exports.
Attachments
Patch (8.68 KB, patch)
2020-02-03 16:00 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (8.68 KB, patch)
2020-02-03 16:06 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (8.67 KB, patch)
2020-02-03 17:04 PST, Don Olmstead 		ysuzuki: review+
DetailsFormatted DiffDiff
Patch (9.04 KB, patch)
2020-02-04 16:23 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2020-02-03 16:00:26 PST Comment hidden (obsolete)
Don Olmstead
Comment 2 2020-02-03 16:06:01 PST Comment hidden (obsolete)
Don Olmstead
Comment 3 2020-02-03 17:04:17 PST
Created attachment 389605 [details] Patch
Yusuke Suzuki
Comment 4 2020-02-04 12:39:38 PST
Comment on attachment 389605 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389605&action=review r=me > Source/bmalloc/bmalloc/BPlatform.h:286 > +#elif defined(__GNUC__) Use `BCOMPILER(GCC_COMPATIBLE)` here.
Don Olmstead
Comment 5 2020-02-04 16:23:52 PST
Created attachment 389736 [details] Patch
WebKit Commit Bot
Comment 6 2020-02-05 10:37:47 PST
Comment on attachment 389736 [details] Patch Clearing flags on attachment: 389736 Committed r255829: <https://trac.webkit.org/changeset/255829>
WebKit Commit Bot
Comment 7 2020-02-05 10:37:49 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2020-02-05 10:38:16 PST
<rdar://problem/59193595>
Note You need to log in before you can comment on or make changes to this bug.