Bug 207140

Summary:

[iOS 13] Dragging on-screen volume control on a YouTube video selects text around the panel

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

HTML Editing

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, commit-queue, dino, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+, commit-queue: commit-queue-

Wenson Hsieh

Reported 2020-02-03 12:57:27 PST

<rdar://problem/58852938>

Attachments
Patch (11.50 KB, patch) 2020-02-03 13:30 PST, Wenson Hsieh	thorton: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Wenson Hsieh

Comment 1 2020-02-03 13:30:36 PST

Created attachment 389554 [details] Patch

WebKit Commit Bot

Comment 2 2020-02-03 14:45:53 PST Comment hidden (obsolete)

Comment on attachment 389554 [details] Patch Rejecting attachment 389554 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 389554, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=389554&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=207140&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 389554 from bug 207140. Fetching: https://bugs.webkit.org/attachment.cgi?id=389554 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... A LayoutTests/editing/selection/ios/prefer-drag-over-text-selection-expected.txt A LayoutTests/editing/selection/ios/prefer-drag-over-text-selection.html M LayoutTests/ChangeLog ERROR from SVN: Item is out of date: File '/trunk/LayoutTests/ChangeLog' is out of date W: bce39b4d0a166df39a827d9f01a4095bb801bd63 and refs/remotes/origin/master differ, using rebase: :040000 040000 8d866235bb2f49e0ad9c86a728686fd9b32481c8 bd89f801235ecefcecc600cba3a8fc8f17913394 M LayoutTests :040000 040000 25442da87c0289c03b186e20b3db48ad56110391 29d51cbf867d00b16d5f8901c9ea8fe079055615 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... A LayoutTests/editing/selection/ios/prefer-drag-over-text-selection-expected.txt A LayoutTests/editing/selection/ios/prefer-drag-over-text-selection.html M LayoutTests/ChangeLog ERROR from SVN: Item is out of date: File '/trunk/LayoutTests/ChangeLog' is out of date W: bce39b4d0a166df39a827d9f01a4095bb801bd63 and refs/remotes/origin/master differ, using rebase: :040000 040000 8d866235bb2f49e0ad9c86a728686fd9b32481c8 bd89f801235ecefcecc600cba3a8fc8f17913394 M LayoutTests :040000 040000 25442da87c0289c03b186e20b3db48ad56110391 29d51cbf867d00b16d5f8901c9ea8fe079055615 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From https://git.webkit.org/git/WebKit c50bb8452ef..81117570547 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 255595 = c50bb8452efd1b11e40ad2148ad2a3a2b84d7dcf r255596 = 61de34cf1803d680d7882cc1639c6c9998214e2c r255597 = 1bd2a61c132ab37b0e80b866908fa6b65481d3fd r255598 = 8111757054776d43a5cf1458ebfff963de7de3c3 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: https://webkit-queues.webkit.org/results/13316222

Wenson Hsieh

Comment 3 2020-02-03 15:10:18 PST

Committed r255603: <https://trac.webkit.org/changeset/255603>

Note You need to log in before you can comment on or make changes to this bug.