Summary: | Crash in WebCore::IDBServer::IDBServer::createIndex | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sihui Liu <sihui_liu> | ||||||||
Component: | New Bugs | Assignee: | Sihui Liu <sihui_liu> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | alecflett, beidson, cdumez, commit-queue, darin, ews-watchlist, jsbell, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Sihui Liu
2020-02-03 11:54:14 PST
Created attachment 389544 [details]
Patch
That's a lot of red bubbles you got there :) Comment on attachment 389544 [details]
Patch
Need to add WEBCORE_EXPORT to the function.
Created attachment 389581 [details]
Patch
Comment on attachment 389581 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389581&action=review > Source/WebCore/ChangeLog:11 > + No behavior change. > + > + * Modules/indexeddb/shared/IDBIndexInfo.h: This is not a great way to write the change log. Ideally the comment on the file would say something like "Export IDBIndexInfo::isolatedCopy so it can be used in WebKitLegacy framework code." Replacing the line about testing with "No behavior change" is also not great. Just deleting it is better. After all, the patch does create a behavior change, although it’s the part of the change in WebKitLegacy rather than the part in WebCore, so it’s not accurate. > Source/WebKitLegacy/ChangeLog:9 > + Create an isolated copy of IDBIndexInfo before passing it to IDB thread. Seems like this comment should be on the function line rather than up here. (In reply to Darin Adler from comment #6) > Comment on attachment 389581 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=389581&action=review > > > Source/WebCore/ChangeLog:11 > > + No behavior change. > > + > > + * Modules/indexeddb/shared/IDBIndexInfo.h: > > This is not a great way to write the change log. Ideally the comment on the > file would say something like "Export IDBIndexInfo::isolatedCopy so it can > be used in WebKitLegacy framework code." > > Replacing the line about testing with "No behavior change" is also not > great. Just deleting it is better. After all, the patch does create a > behavior change, although it’s the part of the change in WebKitLegacy rather > than the part in WebCore, so it’s not accurate. > > > Source/WebKitLegacy/ChangeLog:9 > > + Create an isolated copy of IDBIndexInfo before passing it to IDB thread. > > Seems like this comment should be on the function line rather than up here. Will change. Thanks for the review! Created attachment 389585 [details]
Patch for landing
Comment on attachment 389585 [details] Patch for landing Clearing flags on attachment: 389585 Committed r255615: <https://trac.webkit.org/changeset/255615> All reviewed patches have been landed. Closing bug. |