Bug 207118 – run-javascriptcore-tests: Don't split binary results

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Jonathan Bedard]

Experience over the last 2 months has shown that attempting to split up results from a single JSC test binary doesn't really work. We should just report aggregated results for a single binary.

[Jonathan Bedard]

Created attachment 389515 [details]
Patch

[Jonathan Bedard]

https://results.webkit.org/suites?suite=javascriptcore-tests demonstrates how my original approach basically failed.

[Zhifei Fang]

Comment on attachment 389515 [details]
Patch

unofficially r+, in long term we should unify all the test output format, and let those binaries generate that standard output

[Aakash Jain]

(In reply to Jonathan Bedard from comment #0)
> Experience over the last 2 months has shown that attempting to split up results from a single JSC test binary doesn't really work.
What's the issue?

[Jonathan Bedard]

(In reply to Aakash Jain from comment #4)
> (In reply to Jonathan Bedard from comment #0)
> > Experience over the last 2 months has shown that attempting to split up results from a single JSC test binary doesn't really work.
> What's the issue?

We can't really do it consistently, a sub-test which fails will sometimes have a different name than when it passes and often, exception messages will be tagged as actual test names.

[Aakash Jain]

rs=me

[Jonathan Bedard]

Committed r255578: <https://trac.webkit.org/changeset/255578>

[Radar WebKit Bug Importer]

<rdar://problem/59118504>