Summary: | ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) on animations/keyframe-autoclose-brace.html | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jason Lawrence <Lawrence.j> | ||||||
Component: | Animations | Assignee: | Antoine Quint <graouts> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, dino, graouts, Hironori.Fujii, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=204776 | ||||||||
Attachments: |
|
Description
Jason Lawrence
2020-01-31 14:58:33 PST
Created attachment 389425 [details]
Update Test Expectations
Comment on attachment 389425 [details] Update Test Expectations Clearing flags on attachment: 389425 Committed r255525: <https://trac.webkit.org/changeset/255525> This is almost 100% asserting, almost certainly a regression from http://trac.webkit.org/r251543 Created attachment 389480 [details]
Patch
Comment on attachment 389480 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389480&action=review > Source/WebCore/ChangeLog:10 > + We cannot add CSSPropertyInvalid to a HashSet<CSSPropertyID>, because it triggers an ASSERT, and also we shouldn't > + because we wouldn't know how to animate that CSS property. Can you write a test that would have reproducibly crashed? How did we get an invalid property? The commit-queue encountered the following flaky tests while processing attachment 389480 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 389480 [details] Patch Clearing flags on attachment: 389480 Committed r255552: <https://trac.webkit.org/changeset/255552> All reviewed patches have been landed. Closing bug. *** Bug 204776 has been marked as a duplicate of this bug. *** |