Bug 20693
| Summary: | REGRESSION(r36016): JavaScriptCore no longer builds with GCC 4.2 due to strict aliasing violations | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Rowe (bdash) <mrowe> |
| Component: | JavaScriptCore | Assignee: | Sam Weinig <sam> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ggaren, sam |
| Priority: | P2 | Keywords: | Regression |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.5 | ||
Mark Rowe (bdash)
The warnings are as follows:
kjs/PropertyMap.h: In member function 'KJS::JSValue* KJS::PropertyMap::getOffset(size_t)':
kjs/PropertyMap.h:102: warning: dereferencing type-punned pointer will break strict-aliasing rules
kjs/PropertyMap.h: In member function 'void KJS::PropertyMap::putOffset(size_t, KJS::JSValue*)':
kjs/PropertyMap.h:107: warning: dereferencing type-punned pointer will break strict-aliasing rules
kjs/PropertyMap.h: In member function 'size_t KJS::PropertyMap::offsetForTableLocation(KJS::JSValue**)':
kjs/PropertyMap.h:133: warning: dereferencing type-punned pointer will break strict-aliasing rules
I believe this was introduced by <http://trac.webkit.org/changeset/36016>.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sam Weinig
I will be fixing this shortly.
Alexey Proskuryakov
Is this still an issue?
Mark Rowe (bdash)
Nope. JavaScriptCore has defaulted to GCC 4.2 for a while now, so we'd have noticed if things were broke.