Bug 206838

Summary: WebCore: Guard uneven corners in rounded rectangles
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, darin, dbates, ews-watchlist, sabouhallawa, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=206096
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Jonathan Bedard
Reported 2020-01-27 13:03:05 PST
Per Darin's comments in https://bugs.webkit.org/show_bug.cgi?id=206096, we should add USE(CG_PATH_ADD_UNEVEN_CORNERS_ROUNDEDRECT)
Attachments
Patch (2.45 KB, patch)
2020-01-27 13:12 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (2.32 KB, patch)
2020-01-27 15:38 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (2.33 KB, patch)
2020-01-28 08:37 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2020-01-27 13:03:37 PST
Not 100% certain this should be a USE macro, but it seems more fitting then a HAVE macro.
Jonathan Bedard
Comment 2 2020-01-27 13:12:25 PST
Created attachment 388889 [details] Patch
Simon Fraser (smfr)
Comment 3 2020-01-27 13:23:21 PST
Comment on attachment 388889 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388889&action=review > Source/WTF/wtf/PlatformUse.h:312 > +#define USE_CG_PATH_ADD_UNEVEN_CORNERS_ROUNDEDRECT 1 I think this should be a HAVE_ in PlatformHave.h
Jonathan Bedard
Comment 4 2020-01-27 15:38:34 PST
Created attachment 388928 [details] Patch
Darin Adler
Comment 5 2020-01-27 16:40:48 PST
Comment on attachment 388928 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388928&action=review > Source/WTF/wtf/PlatformHave.h:569 > +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) || PLATFORM(IOS) || PLATFORM(MACCATALYST) I think we might want to consider a slightly more forward-looking version of the check: #if PLATFORM(COCOA) && !(PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 101400) && !PLATFORM(WATCHOS) && !PLATFORM(APPLETV)
Jonathan Bedard
Comment 6 2020-01-28 08:37:07 PST
Created attachment 389002 [details] Patch
WebKit Commit Bot
Comment 7 2020-01-28 10:10:55 PST
Comment on attachment 389002 [details] Patch Clearing flags on attachment: 389002 Committed r255255: <https://trac.webkit.org/changeset/255255>
WebKit Commit Bot
Comment 8 2020-01-28 10:10:57 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2020-01-28 10:11:12 PST
<rdar://problem/58959405>
Note You need to log in before you can comment on or make changes to this bug.