Bug 20680

Summary:

Need to support comma separated list of key times in keyframes selectors

Product:

WebKit

Reporter:

Chris Marrin <cmarrin>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
Patch, including LayoutTest file	none
Fixed small nits in patch (capitalization, etc.)	hyatt: review+

Chris Marrin

Reported 2008-09-05 17:40:14 PDT

The spec says the key times can be "a comma-separated list of percentage values". But the syntax currently only supports a single key time.

Attachments
Patch, including LayoutTest file (17.85 KB, patch) 2008-09-08 14:43 PDT, Chris Marrin	no flags	Details Formatted Diff Diff
Fixed small nits in patch (capitalization, etc.) (17.85 KB, patch) 2008-09-08 15:03 PDT, Chris Marrin	hyatt: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Chris Marrin

Comment 1 2008-09-08 14:43:48 PDT

Created attachment 23271 [details] Patch, including LayoutTest file

Chris Marrin

Comment 2 2008-09-08 15:03:15 PDT

Created attachment 23274 [details] Fixed small nits in patch (capitalization, etc.)

Dave Hyatt

Comment 3 2008-09-11 15:15:00 PDT

Comment on attachment 23274 [details] Fixed small nits in patch (capitalization, etc.) r=me

Dean Jackson

Comment 4 2008-09-11 17:37:11 PDT

Committed r36347 M WebCore/ChangeLog M WebCore/css/CSSStyleSelector.cpp M WebCore/css/WebKitCSSKeyframesRule.cpp M WebCore/css/CSSParser.cpp M WebCore/css/CSSGrammar.y M WebCore/css/WebKitCSSKeyframeRule.cpp M WebCore/css/WebKitCSSKeyframeRule.h M WebCore/css/WebKitCSSKeyframesRule.h M WebCore/css/CSSParser.h M WebCore/page/animation/AnimationBase.cpp M LayoutTests/ChangeLog A LayoutTests/animations/keyframes-comma-separated-expected.txt A LayoutTests/animations/keyframes-comma-separated.html

Note You need to log in before you can comment on or make changes to this bug.