Bug 206744

Summary: [LFC][Painting] Add Display::Run cleanup to TextPainter::clearGlyphDisplayLists
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, mmaxfield, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

zalan
Reported 2020-01-24 07:21:16 PST
ssia
Attachments
Patch (1.57 KB, patch)
2020-01-24 07:28 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (1.61 KB, patch)
2020-01-24 07:34 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (1.86 KB, patch)
2020-01-24 07:39 PST, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-01-24 07:21:35 PST
<rdar://problem/58867112>
zalan
Comment 2 2020-01-24 07:28:27 PST
Created attachment 388686 [details] Patch
zalan
Comment 3 2020-01-24 07:32:43 PST
ifdef all the things
zalan
Comment 4 2020-01-24 07:34:37 PST
Created attachment 388687 [details] Patch
Antti Koivisto
Comment 5 2020-01-24 07:35:53 PST
Comment on attachment 388687 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388687&action=review > Source/WebCore/rendering/TextPainter.cpp:219 > +#if ENABLE(LAYOUT_FORMATTING_CONTEXT) > + GlyphDisplayListCache<Display::Run>::singleton().clear(); > +#endif Could have runtime check too to avoid unnecessary construction of the singleton.
zalan
Comment 6 2020-01-24 07:39:43 PST
Created attachment 388688 [details] Patch
WebKit Commit Bot
Comment 7 2020-01-24 08:42:32 PST
Comment on attachment 388688 [details] Patch Clearing flags on attachment: 388688 Committed r255074: <https://trac.webkit.org/changeset/255074>
WebKit Commit Bot
Comment 8 2020-01-24 08:42:34 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.