Bug 206668

Summary: REGRESSION: [MacOS wk1] fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate.html is flaky failing
Product: WebKit Reporter: Jacob Uphoff <jacob_uphoff>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: ryanhaddad, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Update Test Expectations
none
Update Test Expectations
none
Update Test Expectations
none
Update Test Expectations none

Jacob Uphoff
Reported 2020-01-23 09:28:47 PST
fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate.html is flaky failing and was first seen on commit 252050 but not sure if that is the origin. I did not try to reproduce the failure, it is happening on macOS wk1. History: https://results.webkit.org/?suite=layout-tests&test=fast%2Floader%2Fredirect-to-invalid-url-using-meta-refresh-calls-policy-delegate.html Diff: --- /Volumes/Data/slave/catalina-debug-tests-wk1/build/layout-test-results/fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate-expected.txt +++ /Volumes/Data/slave/catalina-debug-tests-wk1/build/layout-test-results/fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate-actual.txt @@ -1,4 +1,3 @@ -Policy delegate: attempt to load http://a=a&b=b/ with navigation type 'other' Tests that we do not redirect to an invalid URL initiated by <meta http-equiv="refresh">. This test PASSED if you see an entry in the dumped frame load callbacks of the form: "willPerformClientRedirectToURL: http://A=a&B=b" followed by "didCancelClientRedirectForFrame". Note, this test must be run in DumpRenderTree.
Attachments
Update Test Expectations (1.45 KB, patch)
2020-01-28 08:30 PST, Jacob Uphoff 		no flags
DetailsFormatted DiffDiff
Update Test Expectations (1.44 KB, patch)
2020-01-28 08:34 PST, Jacob Uphoff 		no flags
DetailsFormatted DiffDiff
Update Test Expectations (2.04 KB, patch)
2020-01-28 08:46 PST, Jacob Uphoff 		no flags
DetailsFormatted DiffDiff
Update Test Expectations (1.80 KB, patch)
2020-01-28 08:51 PST, Jacob Uphoff 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-01-23 09:29:13 PST
<rdar://problem/58837324>
Truitt Savell
Comment 2 2020-01-23 10:18:46 PST
This test does reproduce easily by running it in iterations. It reproduces on much older builds than the suggested regression point so I still cannot tell when this may have started.
Ryan Haddad
Comment 3 2020-01-23 12:45:23 PST
Looking at this example: https://build.webkit.org/results/Apple-Catalina-Debug-WK1-Tests/r254577%20(1809)/results.html The line that is missing in the diff for fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate.html is unexpectedly present in the diff for fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed-async-delegates.html In every failure I looked at, both tests fail together as described above.
Alexey Proskuryakov
Comment 4 2020-01-24 23:02:50 PST
*** This bug has been marked as a duplicate of bug 180760 ***
Jacob Uphoff
Comment 5 2020-01-28 08:30:40 PST
Reopening to attach new patch.
Jacob Uphoff
Comment 6 2020-01-28 08:30:41 PST
Created attachment 388999 [details] Update Test Expectations
Jacob Uphoff
Comment 7 2020-01-28 08:34:43 PST
Created attachment 389001 [details] Update Test Expectations
Jacob Uphoff
Comment 8 2020-01-28 08:46:07 PST
Created attachment 389005 [details] Update Test Expectations
Jacob Uphoff
Comment 9 2020-01-28 08:51:11 PST
Created attachment 389008 [details] Update Test Expectations
Truitt Savell
Comment 10 2020-01-28 08:53:43 PST
Comment on attachment 389008 [details] Update Test Expectations Clearing flags on attachment: 389008 Committed r255242: <https://trac.webkit.org/changeset/255242>
Ryan Haddad
Comment 11 2020-01-28 09:23:00 PST
*** This bug has been marked as a duplicate of bug 180760 ***
Note You need to log in before you can comment on or make changes to this bug.