Summary: | media/modern-media-controls/media-controller/media-controller-auto-hide.html is flaky timing out | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jacob Uphoff <jacob_uphoff> | ||||||
Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, dino, eric.carlson, ews-watchlist, glenn, graouts, jer.noble, philipj, sergio, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Jacob Uphoff
2020-01-22 16:49:41 PST
Removing REGRESSIOn from the title, since we don't have the evidence of such. That said, with modern media controls themselves being new, this may be uncovering an actual regression. Created attachment 388806 [details]
Patch
Comment on attachment 388806 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388806&action=review > LayoutTests/media/content/test.mp4.js:3 > + return "data:video/mp4;base64," + Not that it matters, but if you used a `` style string you wouldn't need to have all the +es. (In reply to Dean Jackson from comment #4) > Comment on attachment 388806 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=388806&action=review > > > LayoutTests/media/content/test.mp4.js:3 > > + return "data:video/mp4;base64," + > > Not that it matters, but if you used a `` style string you wouldn't need to > have all the +es. Good suggestion, thanks! Created attachment 388808 [details]
Patch for landing
The commit-queue encountered the following flaky tests while processing attachment 388808 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 388808 [details] Patch for landing Clearing flags on attachment: 388808 Committed r255130: <https://trac.webkit.org/changeset/255130> All reviewed patches have been landed. Closing bug. This change seems to have caused media/modern-media-controls/media-controller/media-controller-auto-hide.html to consistently fail an assertion on Mojave debug bots: ASSERTION FAILED: dataRequest.requestedLength >= (dataRequest.currentOffset - dataRequest.requestedOffset) /Volumes/Data/slave/mojave-debug/build/Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm(190) : void WebCore::WebCoreAVFResourceLoader::fulfillRequestWithResource(WebCore::CachedResource &) 1 0x4e5fd8759 WTFCrash 2 0x4cba1407b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x4d02accac WebCore::WebCoreAVFResourceLoader::fulfillRequestWithResource(WebCore::CachedResource&) 4 0x4d02ad5b7 WebCore::WebCoreAVFResourceLoader::notifyFinished(WebCore::CachedResource&) 5 0x4cee821ef WebCore::CachedResource::checkNotify() 6 0x4cee7e071 WebCore::CachedResource::finishLoading(WebCore::SharedBuffer*) 7 0x4cee7f359 WebCore::CachedRawResource::finishLoading(WebCore::SharedBuffer*) 8 0x4cee07501 WebCore::SubresourceLoader::didFinishLoading(WebCore::NetworkLoadMetrics const&) (In reply to Ryan Haddad from comment #10) > This change seems to have caused > media/modern-media-controls/media-controller/media-controller-auto-hide.html > to consistently fail an assertion on Mojave debug bots: This was resolved by r255346 or r255347. |