Bug 206618 – Fix iOS 13.2 iphoneos build

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Jonathan Bedard]

WebKit doesn't build on iOS 13.2 for iphoneos. We need to make a few modifications to our build scripts to make it build.

[Jonathan Bedard]

Created attachment 388477 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 388477 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388477&action=review

> Tools/Scripts/webkitdirs.pm:884
> +    push @options, "-IDEProvisioningProfileSupportRelaxed=YES";

Maybe limit this to embedded platforms? It will be a little confusing when looking at macOS logs for future unrelated failures.

[Jonathan Bedard]

(In reply to Alexey Proskuryakov from comment #2)
> Comment on attachment 388477 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=388477&action=review
> 
> > Tools/Scripts/webkitdirs.pm:884
> > +    push @options, "-IDEProvisioningProfileSupportRelaxed=YES";
> 
> Maybe limit this to embedded platforms? It will be a little confusing when
> looking at macOS logs for future unrelated failures.

We could do this and fix our immediate problem.

But https://bugs.webkit.org/show_bug.cgi?id=206620 would just end up undoing that. We don't pass platform arguments to webkitdirs when doing make, and I had trouble thinking up a situation where relaxing provisioning rules was wrong.

If we think we want to continue passing platform specific arguments to xcodebuild, we need to pass the platform we're using to webkitdirs when running make.

[Jonathan Bedard]

Created attachment 388491 [details]
Patch

[Jonathan Bedard]

Talked a bit with Alexey about this offline.

My reason for applying this argument globally was some issues with https://bugs.webkit.org/show_bug.cgi?id=206620, but that is actually indicative of a larger bug in how make invokes webkitdirs. For now, we'll do this for embedded builds only, and address the make issues in https://bugs.webkit.org/show_bug.cgi?id=206620.

[WebKit Commit Bot]

Comment on attachment 388491 [details]
Patch

Rejecting attachment 388491 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 388491, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=388491&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=206618&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 388491 from bug 206618.
Fetching: https://bugs.webkit.org/attachment.cgi?id=388491
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/Scripts/webkitdirs.pm
Hunk #1 FAILED at 888.
1 out of 1 hunk FAILED -- saving rejects to file Tools/Scripts/webkitdirs.pm.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/13310391

[Jonathan Bedard]

Committed r254978: <https://trac.webkit.org/changeset/254978>

[Radar WebKit Bug Importer]

<rdar://problem/58835552>