Bug 206505

Summary:

Fix missing header guards and clean up empty files in WebCore, WebKitLegacy, WebKit, Tools

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

WebKit Misc.

Assignee:

David Kilzer (:ddkilzer) <ddkilzer>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cgarcia, commit-queue, eric.carlson, ews-watchlist, glenn, hta, jer.noble, joepeck, mifenton, philipj, sergio, tommyw, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=206480
https://bugs.webkit.org/show_bug.cgi?id=206481

Attachments:

Description	Flags
Patch v1	none

David Kilzer (:ddkilzer)

Reported 2020-01-20 09:27:41 PST

Fix missing header guards and clean up empty files in WebCore, WebKitLegacy, WebKit, Tools. See Bug 206480 Comment #6 for WebCore, WebKitLegacy, WebKit. Here are the Tools directories I checked: $ ./Tools/Scripts/check-webkit-style --filter=-,+build/header_guard_missing Tools/DumpRenderTree Tools/WebKitTestRunner Tools/TestRunnerShared Tools/TestWebKitAPI ERROR: Tools/DumpRenderTree/win/resource.h:5: Missing #pragma once for header guard. [build/header_guard_missing] [5] ERROR: Tools/DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:3: Missing #pragma once for header guard. [build/header_guard_missing] [5] ERROR: Tools/DumpRenderTree/TestNetscapePlugIn/TestObject.h:26: Missing #pragma once for header guard. [build/header_guard_missing] [5] ERROR: Tools/DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:3: Missing #pragma once for header guard. [build/header_guard_missing] [5] ERROR: Tools/DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:3: Missing #pragma once for header guard. [build/header_guard_missing] [5] ERROR: Tools/DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:3: Missing #pragma once for header guard. [build/header_guard_missing] [5] ERROR: Tools/TestWebKitAPI/JavaScriptTest.h:26: Missing #pragma once for header guard. [build/header_guard_missing] [5] WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp" WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp" WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp" WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp" WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp" WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp" WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp" WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/InspectorTestServer.cpp" WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp" WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp" WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp" WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp" WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp" WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp" WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp" WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp" WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp" WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp" WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp" WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp" WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp" WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp" ERROR: Tools/TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:20: Missing #pragma once for header guard. [build/header_guard_missing] [5] ERROR: Tools/TestWebKitAPI/Tests/WebCore/DFAHelpers.h:26: Missing #pragma once for header guard. [build/header_guard_missing] [5] Total errors found: 9 in 1735 files

Attachments
Patch v1 (35.86 KB, patch) 2020-01-20 09:41 PST, David Kilzer (:ddkilzer)	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

David Kilzer (:ddkilzer)

Comment 1 2020-01-20 09:41:45 PST

Created attachment 388246 [details] Patch v1

David Kilzer (:ddkilzer)

Comment 2 2020-01-20 09:45:15 PST

Headers I didn't fix in this patch: Source/WebKitLegacy/win/resource.h Tools/DumpRenderTree/win/resource.h - Headers generated by Microsoft Visual C++. Tools/DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h Tools/DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h Tools/DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h - Forwarding headers have never had header guards, and are increasingly rarely used. Source/WebKit/NetworkProcess/glib/WebKitCachedResolver.h Tools/TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h - Didn't touch GTK-related headers.

WebKit Commit Bot

Comment 3 2020-01-20 13:21:23 PST

Comment on attachment 388246 [details] Patch v1 Clearing flags on attachment: 388246 Committed r254836: <https://trac.webkit.org/changeset/254836>

WebKit Commit Bot

Comment 4 2020-01-20 13:21:25 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 5 2020-01-20 13:22:16 PST

<rdar://problem/58743410>

Note You need to log in before you can comment on or make changes to this bug.