Bug 206492

Summary: Import 2 sets of grid-align-tests from WPT
Product: WebKit Reporter: rmonteriso
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, jfernandez, rego, rmonteriso, svillar, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

rmonteriso
Reported 2020-01-20 02:25:09 PST
This patch moves some grid-align tests to the imported/w3c/web-platform-tests after they have been adapted and merged in the WPT repository: https://github.com/web-platform-tests/wpt/pull/19862/ * css/css-grid/alignment/grid-align-stretching-replaced-items.html * css/support/blue-100.png https://github.com/web-platform-tests/wpt/pull/19823/ * css/css-grid/alignment/grid-align-content-vertical-lr.html * css/css-grid/alignment/grid-align-content-vertical-rl.html Their corresponding outdated tests in fast/css-grid-layout have been removed.
Attachments
Patch (44.19 KB, patch)
2020-01-22 02:45 PST, rmonteriso 		no flags
DetailsFormatted DiffDiff
Patch (44.16 KB, patch)
2020-01-23 03:32 PST, rmonteriso 		no flags
DetailsFormatted DiffDiff
Patch (47.45 KB, patch)
2020-01-23 10:08 PST, rmonteriso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
rmonteriso
Comment 1 2020-01-22 02:45:14 PST
Created attachment 388409 [details] Patch
rmonteriso
Comment 2 2020-01-23 03:32:40 PST
Created attachment 388532 [details] Patch
rmonteriso
Comment 3 2020-01-23 10:08:39 PST
Created attachment 388559 [details] Patch
Manuel Rego Casasnovas
Comment 4 2020-01-24 00:44:53 PST
Comment on attachment 388559 [details] Patch r=me assuming that the tests under imported/w3c/ are synced with the ones in WPT.
rmonteriso
Comment 5 2020-01-24 01:55:25 PST
Yes, these tests are updated to the latest version of WPT tests and incorporate the cosmetic change introduced by the following Chromium CL: https://chromium-review.googlesource.com/c/chromium/src/+/2010769
Manuel Rego Casasnovas
Comment 6 2020-01-24 02:32:19 PST
Comment on attachment 388559 [details] Patch (In reply to rmonteriso from comment #5) > Yes, these tests are updated to the latest version of WPT tests and > incorporate the cosmetic change introduced by the following Chromium CL: > https://chromium-review.googlesource.com/c/chromium/src/+/2010769 Great, the Chromium CL has landed and merged in WPT so we can land this now.
WebKit Commit Bot
Comment 7 2020-01-24 03:18:10 PST
Comment on attachment 388559 [details] Patch Clearing flags on attachment: 388559 Committed r255064: <https://trac.webkit.org/changeset/255064>
WebKit Commit Bot
Comment 8 2020-01-24 03:18:11 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2020-01-24 03:19:14 PST
<rdar://problem/58863943>
Note You need to log in before you can comment on or make changes to this bug.