Bug 206468

Summary: [Media in GPU process] Pipe more MediaPlayerPrivate and client methods
Product: WebKit Reporter: Jon Lee <jonlee>
Component: MediaAssignee: Jon Lee <jonlee>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cdumez, commit-queue, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, peng.liu6, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Jon Lee
Reported 2020-01-17 23:58:31 PST
Pipe more MediaPlayerPrivate and client methods
Attachments
Patch (19.54 KB, patch)
2020-01-18 00:25 PST, Jon Lee 		no flags
DetailsFormatted DiffDiff
Patch (20.32 KB, patch)
2020-01-18 16:50 PST, Jon Lee 		no flags
DetailsFormatted DiffDiff
Patch (22.46 KB, patch)
2020-01-22 15:13 PST, Jon Lee 		no flags
DetailsFormatted DiffDiff
Patch (22.44 KB, patch)
2020-01-22 16:13 PST, Jon Lee 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jon Lee
Comment 1 2020-01-18 00:25:44 PST
Created attachment 388136 [details] Patch
Eric Carlson
Comment 2 2020-01-18 10:02:02 PST
Comment on attachment 388136 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388136&action=review > Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:476 > + m_webProcessConnection->send(Messages::RemoteMediaPlayerManager::CurrentPlaybackTargetIsWirelessChanged(m_id), 0); HTMLMediaElement::mediaPlayerCurrentPlaybackTargetIsWirelessChanged immediately calls m_player->isCurrentPlaybackTargetWireless(), so we should push that state here and cache it in the MediaPlayerPrivateRemote. > Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:684 > + if (m_player) m_player is never NULL. > Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:942 > + if (m_player) Ditto. > Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:948 > + if (m_player) Ditto. > Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:954 > + if (m_player) Ditto.
Jon Lee
Comment 3 2020-01-18 16:50:30 PST
Created attachment 388162 [details] Patch
Eric Carlson
Comment 4 2020-01-18 17:31:48 PST
Comment on attachment 388162 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388162&action=review Thanks! > Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:815 > + if (m_player) This test is unnecessary.
Jon Lee
Comment 5 2020-01-19 21:32:58 PST
Comment on attachment 388162 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388162&action=review >> Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:815 >> + if (m_player) > > This test is unnecessary. Whoops, will remove.
Jon Lee
Comment 6 2020-01-22 15:13:25 PST
Created attachment 388474 [details] Patch
Eric Carlson
Comment 7 2020-01-22 15:20:18 PST
Comment on attachment 388474 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388474&action=review > Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:815 > + if (m_player) :-/
Jon Lee
Comment 8 2020-01-22 16:13:03 PST
Created attachment 388481 [details] Patch
WebKit Commit Bot
Comment 9 2020-01-22 22:31:39 PST
Comment on attachment 388481 [details] Patch Clearing flags on attachment: 388481 Committed r254964: <https://trac.webkit.org/changeset/254964>
WebKit Commit Bot
Comment 10 2020-01-22 22:31:41 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2020-01-22 22:32:13 PST
<rdar://problem/58825046>
Note You need to log in before you can comment on or make changes to this bug.