Bug 206462

Summary: ProvisionalPageProxy::loadData should pass last navigation's shouldOpenExternalURLsPolicy flag to WebPageProxy
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebKit Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jiewen Tan
Reported 2020-01-17 17:42:47 PST
ProvisionalPageProxy::loadData should pass last navigation's shouldOpenExternalURLsPolicy flag to WebPageProxy.
Attachments
Patch (9.08 KB, patch)
2020-01-17 17:46 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jiewen Tan
Comment 1 2020-01-17 17:43:15 PST
<rdar://problem/57468718>
Jiewen Tan
Comment 2 2020-01-17 17:46:41 PST
Created attachment 388123 [details] Patch
Chris Dumez
Comment 3 2020-01-21 08:37:36 PST
Comment on attachment 388123 [details] Patch Please look into API test failures.
Jiewen Tan
Comment 4 2020-01-21 13:45:37 PST
Comment on attachment 388123 [details] Patch Thanks Chris for r+ the patch.
WebKit Commit Bot
Comment 5 2020-01-21 14:16:30 PST
The commit-queue encountered the following flaky tests while processing attachment 388123 [details]: imported/w3c/web-platform-tests/IndexedDB/fire-success-event-exception.html bug 206554 (authors: shvaikalesh@gmail.com and youennf@gmail.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2020-01-21 14:16:55 PST
The commit-queue encountered the following flaky tests while processing attachment 388123 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2020-01-21 14:51:45 PST
Comment on attachment 388123 [details] Patch Clearing flags on attachment: 388123 Committed r254884: <https://trac.webkit.org/changeset/254884>
WebKit Commit Bot
Comment 8 2020-01-21 14:51:47 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.