Bug 206448

Summary: [JSC] Add missing header guards
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: JavaScriptCoreAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, fpizlo, jfbastien, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=206480
https://bugs.webkit.org/show_bug.cgi?id=206481
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2020-01-17 15:18:21 PST
Add missing header guards to JavaScriptCore headers as found by lgtm.com: Source/JavaScriptCore/heap/IsoHeapCellType.h Source/JavaScriptCore/wasm/WasmFaultSignalHandler.h
Attachments
Patch v1 (2.17 KB, patch)
2020-01-17 15:21 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2020-01-17 15:21:12 PST
Created attachment 388095 [details] Patch v1
Keith Miller
Comment 2 2020-01-17 18:20:46 PST
Lol, we should really have a style warning for this...
WebKit Commit Bot
Comment 3 2020-01-17 18:49:39 PST
Comment on attachment 388095 [details] Patch v1 Clearing flags on attachment: 388095 Committed r254787: <https://trac.webkit.org/changeset/254787>
WebKit Commit Bot
Comment 4 2020-01-17 18:49:40 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2020-01-17 18:50:18 PST
<rdar://problem/58703846>
David Kilzer (:ddkilzer)
Comment 6 2020-01-18 22:39:44 PST
(In reply to Keith Miller from comment #2) > Lol, we should really have a style warning for this... We do have a check, but it wasn't very good because it assumed any header that didn't already have #ifndef/#define/#endif or #pragma once was an Objective-C header that didn't need a header guard. Improving this in Bug 206480.
Note You need to log in before you can comment on or make changes to this bug.