Bug 206408

Summary: Video sound sometimes keeps playing in page cache
Product: WebKit Reporter: youenn fablet <youennf>
Component: MediaAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cdumez, commit-queue, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

youenn fablet
Reported 2020-01-17 04:01:05 PST
Video sound sometimes keeps playing in page cache
Attachments
Patch (36.27 KB, patch)
2020-01-17 04:07 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (36.07 KB, patch)
2020-01-20 00:08 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-01-17 04:01:14 PST
<rdar://problem/58654047>
youenn fablet
Comment 2 2020-01-17 04:07:53 PST
Created attachment 388026 [details] Patch
Eric Carlson
Comment 3 2020-01-17 09:06:39 PST
Comment on attachment 388026 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388026&action=review > LayoutTests/http/tests/navigation/resources/page-cache-video-helper.html:7 > + localStorage.setItem("pageMediaState", internals.pageMediaState()); This state is never read back from the page cache, should it be?
youenn fablet
Comment 4 2020-01-17 09:15:01 PST
(In reply to Eric Carlson from comment #3) > Comment on attachment 388026 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=388026&action=review > > > LayoutTests/http/tests/navigation/resources/page-cache-video-helper.html:7 > > + localStorage.setItem("pageMediaState", internals.pageMediaState()); > > This state is never read back from the page cache, should it be? No, I forgot to remove it. I initially planned to use that state but this was not testing what I wanted so ended up with currentTime. Will remove it before landing.
youenn fablet
Comment 5 2020-01-20 00:08:09 PST
Created attachment 388208 [details] Patch
WebKit Commit Bot
Comment 6 2020-01-20 01:23:14 PST
Comment on attachment 388208 [details] Patch Clearing flags on attachment: 388208 Committed r254814: <https://trac.webkit.org/changeset/254814>
WebKit Commit Bot
Comment 7 2020-01-20 01:23:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.