| Summary: | Setting kVTCompressionPropertyKey_DataRateLimits on RTCVideoEncoderH264 fails | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
youenn fablet
2020-01-17 00:19:19 PST
Created attachment 388017 [details]
Patch
Comment on attachment 388017 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388017&action=review > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/helpers.cc:134 > + RTC_LOG(LS_ERROR) << "VTSessionSetProperty failed to set: " << key_string it might be worth also logging 'vtSession' so we know which call was made Created attachment 388213 [details]
Patch for landing
The commit-queue encountered the following flaky tests while processing attachment 388213 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 388213 [details] Patch for landing Clearing flags on attachment: 388213 Committed r254815: <https://trac.webkit.org/changeset/254815> All reviewed patches have been landed. Closing bug. |