Bug 206385

Summary: [iOS] Focusing editable element with WebPage::selectPositionAtPoint() does not bring up keyboard
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebKit2Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
For bots
none
Patch
none
To Land none

Daniel Bates
Reported 2020-01-16 16:30:06 PST
When a hardware keyboard is not attached calling WebPage::selectPositionAtPoint() to focus an editable element does not bring up the keyboard.
Attachments
For bots (1.56 KB, patch)
2020-01-16 16:31 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (2.34 KB, patch)
2020-01-17 10:42 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
To Land (2.33 KB, patch)
2020-01-17 10:57 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2020-01-16 16:30:11 PST
<rdar://problem/57414380>
Daniel Bates
Comment 2 2020-01-16 16:31:57 PST
Created attachment 387981 [details] For bots
Daniel Bates
Comment 3 2020-01-17 10:42:38 PST
Created attachment 388057 [details] Patch
Wenson Hsieh
Comment 4 2020-01-17 10:45:12 PST
Comment on attachment 388057 [details] Patch This would preferably have a test. I think you could write an API test for this that verifies -[_WKFocusedElementInfo userInitiated] is YES when using selectPositionAtPoint in a text field.
Wenson Hsieh
Comment 5 2020-01-17 10:50:52 PST
Comment on attachment 388057 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388057&action=review > Source/WebKit/ChangeLog:14 > + tagged selection change though the callers should be auditted to ensure they weren't accidentally Nit - auditted
Daniel Bates
Comment 6 2020-01-17 10:54:44 PST
Comment on attachment 388057 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388057&action=review Thanks for the review! >> Source/WebKit/ChangeLog:14 >> + tagged selection change though the callers should be auditted to ensure they weren't accidentally > > Nit - auditted I'll audit it!
Daniel Bates
Comment 7 2020-01-17 10:57:02 PST
Created attachment 388063 [details] To Land
Daniel Bates
Comment 8 2020-01-17 11:00:02 PST
Comment on attachment 388063 [details] To Land Clearing flags on attachment: 388063 Committed r254755: <https://trac.webkit.org/changeset/254755>
Daniel Bates
Comment 9 2020-01-17 11:00:04 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.