Bug 206325

Summary: Add finite timeout when synchronously terminating a service worker
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 207354    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2020-01-15 16:37:00 PST
Add finite timeout when synchronously terminating a service worker
Attachments
Patch (1.94 KB, patch)
2020-01-15 16:38 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (6.64 KB, patch)
2020-01-15 17:27 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (6.43 KB, patch)
2020-01-16 13:07 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-01-15 16:38:33 PST
Created attachment 387869 [details] Patch
Alex Christensen
Comment 2 2020-01-15 16:38:36 PST
<rdar://problem/58183380>
Alex Christensen
Comment 3 2020-01-15 17:27:57 PST
Created attachment 387875 [details] Patch
youenn fablet
Comment 4 2020-01-16 02:39:16 PST
Comment on attachment 387875 [details] Patch LGTM. In the future, we should be able to remove this syncTerminateWorker and use a timer to kick in process termination if it does not answer soon enough. View in context: https://bugs.webkit.org/attachment.cgi?id=387875&action=review > Source/WebKit/ChangeLog:11 > + and tell the UI process to terminate the hanging service worker process. Continue handling messages during s/. C/. C/ > Source/WebKit/UIProcess/WebProcessPool.cpp:1771 > +void WebProcessPool::terminateServiceWorkers(const WebCore::RegistrableDomain& domain, const PAL::SessionID& sessionID) s/terminateServiceWorkers/terminateServiceWorkerProcess? > Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:429 > + for (auto processPool : WebProcessPool::allProcessPools()) auto* > Source/WebKit/UIProcess/Network/NetworkProcessProxy.h:39 > +#include <WebCore/ServiceWorkerIdentifier.h> Does not seem necessary
Alex Christensen
Comment 5 2020-01-16 13:07:32 PST
Created attachment 387946 [details] Patch
WebKit Commit Bot
Comment 6 2020-01-16 13:45:55 PST
Comment on attachment 387946 [details] Patch Clearing flags on attachment: 387946 Committed r254706: <https://trac.webkit.org/changeset/254706>
WebKit Commit Bot
Comment 7 2020-01-16 13:45:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.