Summary: | Web Inspector: add links to reference pages | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes, joepeck, timothy, webkit-bug-importer | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Local Build | ||||||||||||||||
Hardware: | All | ||||||||||||||||
OS: | All | ||||||||||||||||
Attachments: |
|
Description
Devin Rousso
2020-01-15 13:02:12 PST
Created attachment 387833 [details]
Patch
Created attachment 387835 [details]
Patch
Created attachment 387836 [details]
[Image] After Patch is applied
The "Web Inspector Reference" link in the popover feels wrong. Was a (?) like icon considered for cases like this where the link and text take up a lot of space? (In reply to Joseph Pecoraro from comment #4) > The "Web Inspector Reference" link in the popover feels wrong. Was a (?) like icon considered for cases like this where the link and text take up a lot of space? Tim suggested this internally. I'm not opposed to it, but I do feel like it is less noticeable/understandable than text. I'll give it a shot tonight and see what it looks like. Created attachment 387979 [details]
Patch
Created attachment 387980 [details]
[Image] After Patch is applied
The (?) help icon looks better in the popover. I would also make the link text in settings be grey to match the goto arrow, so it fits in better. Created attachment 387989 [details]
Patch
Adjusted the "Web Inspector Reference =>" link in the Settings Tab to be grey.
Comment on attachment 387989 [details] Patch Clearing flags on attachment: 387989 Committed r254730: <https://trac.webkit.org/changeset/254730> All reviewed patches have been landed. Closing bug. |