Bug 206309

Summary: Web Inspector: add links to reference pages
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
[Image] After Patch is applied
none
Patch
none
[Image] After Patch is applied
none
Patch none

Devin Rousso
Reported 2020-01-15 13:02:12 PST
Now that <https://webkit.org/web-inspector/> is live, we should create links to it in various places around Web Inspector: - Inspector Bootstrap Script default content - Local Resource popover - JavaScript/Event/URL breakpoint popovers - Device Settings popover - Settings Tab
Attachments
Patch (30.42 KB, patch)
2020-01-15 13:22 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (30.78 KB, patch)
2020-01-15 13:35 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
[Image] After Patch is applied (603.71 KB, image/png)
2020-01-15 13:35 PST, Devin Rousso 		no flags
Details
Patch (36.95 KB, patch)
2020-01-16 16:30 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
[Image] After Patch is applied (618.37 KB, image/png)
2020-01-16 16:31 PST, Devin Rousso 		no flags
Details
Patch (36.98 KB, patch)
2020-01-16 16:50 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2020-01-15 13:22:08 PST
Created attachment 387833 [details] Patch
Devin Rousso
Comment 2 2020-01-15 13:35:19 PST
Created attachment 387835 [details] Patch
Devin Rousso
Comment 3 2020-01-15 13:35:40 PST
Created attachment 387836 [details] [Image] After Patch is applied
Joseph Pecoraro
Comment 4 2020-01-15 16:54:57 PST
The "Web Inspector Reference" link in the popover feels wrong. Was a (?) like icon considered for cases like this where the link and text take up a lot of space?
Devin Rousso
Comment 5 2020-01-15 17:10:52 PST
(In reply to Joseph Pecoraro from comment #4) > The "Web Inspector Reference" link in the popover feels wrong. Was a (?) like icon considered for cases like this where the link and text take up a lot of space? Tim suggested this internally. I'm not opposed to it, but I do feel like it is less noticeable/understandable than text. I'll give it a shot tonight and see what it looks like.
Devin Rousso
Comment 6 2020-01-16 16:30:46 PST
Created attachment 387979 [details] Patch
Devin Rousso
Comment 7 2020-01-16 16:31:03 PST
Created attachment 387980 [details] [Image] After Patch is applied
Timothy Hatcher
Comment 8 2020-01-16 16:47:11 PST
The (?) help icon looks better in the popover. I would also make the link text in settings be grey to match the goto arrow, so it fits in better.
Devin Rousso
Comment 9 2020-01-16 16:50:17 PST
Created attachment 387989 [details] Patch Adjusted the "Web Inspector Reference =>" link in the Settings Tab to be grey.
WebKit Commit Bot
Comment 10 2020-01-16 17:24:39 PST
Comment on attachment 387989 [details] Patch Clearing flags on attachment: 387989 Committed r254730: <https://trac.webkit.org/changeset/254730>
WebKit Commit Bot
Comment 11 2020-01-16 17:24:41 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12 2020-01-16 17:25:18 PST
<rdar://problem/58665440>
Note You need to log in before you can comment on or make changes to this bug.