Bug 206309

Summary: Web Inspector: add links to reference pages
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
[Image] After Patch is applied
none
Patch
none
[Image] After Patch is applied
none
Patch none

Description Devin Rousso 2020-01-15 13:02:12 PST
Now that <https://webkit.org/web-inspector/> is live, we should create links to it in various places around Web Inspector:
 - Inspector Bootstrap Script default content
 - Local Resource popover
 - JavaScript/Event/URL breakpoint popovers
 - Device Settings popover
 - Settings Tab
Comment 1 Devin Rousso 2020-01-15 13:22:08 PST
Created attachment 387833 [details]
Patch
Comment 2 Devin Rousso 2020-01-15 13:35:19 PST
Created attachment 387835 [details]
Patch
Comment 3 Devin Rousso 2020-01-15 13:35:40 PST
Created attachment 387836 [details]
[Image] After Patch is applied
Comment 4 Joseph Pecoraro 2020-01-15 16:54:57 PST
The "Web Inspector Reference" link in the popover feels wrong. Was a (?) like icon considered for cases like this where the link and text take up a lot of space?
Comment 5 Devin Rousso 2020-01-15 17:10:52 PST
(In reply to Joseph Pecoraro from comment #4)
> The "Web Inspector Reference" link in the popover feels wrong. Was a (?) like icon considered for cases like this where the link and text take up a lot of space?
Tim suggested this internally.  I'm not opposed to it, but I do feel like it is less noticeable/understandable than text.  I'll give it a shot tonight and see what it looks like.
Comment 6 Devin Rousso 2020-01-16 16:30:46 PST
Created attachment 387979 [details]
Patch
Comment 7 Devin Rousso 2020-01-16 16:31:03 PST
Created attachment 387980 [details]
[Image] After Patch is applied
Comment 8 Timothy Hatcher 2020-01-16 16:47:11 PST
The (?) help icon looks better in the popover. I would also make the link text in settings be grey to match the goto arrow, so it fits in better.
Comment 9 Devin Rousso 2020-01-16 16:50:17 PST
Created attachment 387989 [details]
Patch

Adjusted the "Web Inspector Reference =>" link in the Settings Tab to be grey.
Comment 10 WebKit Commit Bot 2020-01-16 17:24:39 PST
Comment on attachment 387989 [details]
Patch

Clearing flags on attachment: 387989

Committed r254730: <https://trac.webkit.org/changeset/254730>
Comment 11 WebKit Commit Bot 2020-01-16 17:24:41 PST
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2020-01-16 17:25:18 PST
<rdar://problem/58665440>