Bug 206260

Summary:

Expand WebContent process sandbox with additional syscall

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebKit2

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, jbedard, pvollan, webkit-bug-importer

Priority:

P2

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	pvollan: review+

Brent Fulgham

Reported 2020-01-14 14:20:53 PST

Testing shows that we will improve performance on some platforms by supporting an additional Syscall. This patch revises our sandboxes so that WebKit can use this fast path if available.

Attachments
Patch (2.40 KB, patch) 2020-01-14 14:24 PST, Brent Fulgham	no flags	Details Formatted Diff Diff
Patch (2.49 KB, patch) 2020-02-11 17:27 PST, Brent Fulgham	pvollan: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Brent Fulgham

Comment 1 2020-01-14 14:21:18 PST

<rdar://problem/58580997>

Brent Fulgham

Comment 2 2020-01-14 14:24:54 PST

Created attachment 387702 [details] Patch

Per Arne Vollan

Comment 3 2020-01-14 14:44:38 PST

Comment on attachment 387702 [details] Patch Great! R=me.

WebKit Commit Bot

Comment 4 2020-01-14 17:39:16 PST

Comment on attachment 387702 [details] Patch Clearing flags on attachment: 387702 Committed r254548: <https://trac.webkit.org/changeset/254548>

WebKit Commit Bot

Comment 5 2020-01-14 17:39:17 PST

All reviewed patches have been landed. Closing bug.

WebKit Commit Bot

Comment 6 2020-01-14 22:36:45 PST

Re-opened since this is blocked by bug 206279

Alexey Proskuryakov

Comment 7 2020-01-14 22:37:38 PST

This broke launching WebContent on some internal builds, rolling back.

Jonathan Bedard

Comment 8 2020-01-15 08:28:36 PST

Broke things on Catalina too: https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api-tests&test=TestWebKitAPI.SOAuthorizationRedirect.NSNotificationCenter&test=TestWebKitAPI.SOAuthorizationRedirect.InterceptionCancelWithUI&test=TestWebKitAPI.WebKit.WebGLPolicy

Brent Fulgham

Comment 9 2020-02-11 17:27:17 PST

Created attachment 390471 [details] Patch

Per Arne Vollan

Comment 10 2020-02-12 07:09:25 PST

Comment on attachment 390471 [details] Patch R=me.

Brent Fulgham

Comment 11 2020-02-12 09:05:18 PST

Committed r256439: <https://trac.webkit.org/changeset/256439>

Note You need to log in before you can comment on or make changes to this bug.