Bug 206215

Summary: Always Use CAIRO_OPERATOR_SOURCE to copyRectFromOneSurfaceToAnother
Product: WebKit Reporter: Tomoki Imai <tomoki.imai>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, dino, don.olmstead, ews-watchlist, graouts, Hironori.Fujii, kondapallykalyan, ross.kirsling, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
patch to remove cairoOperator from copyRectFromOneSurfaceToAnother none

Tomoki Imai
Reported 2020-01-13 23:16:55 PST
Most of copyRectFromOneSurfaceToAnother callers passed CAIRO_OPERATOR_SOURCE not to blend. BackingStoreBackendCairoImpl::scroll had copyRectFromOneSurfaceToAnother with the default cairoOperator CAIRO_OPERATOR_OVER, but scrolling should use CAIRO_OPERATOR_SOURCE because there is no need to blend and it can have a performance benefit. copyRectFromOneSurfaceToAnother callers; - https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/graphics/cairo/BackingStoreBackendCairoImpl.cpp?rev=254496#L68 - https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/graphics/cairo/BackingStoreBackendCairoImpl.cpp?rev=254496#L69 - https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextGLCairo.cpp?rev=254496#L72 - https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp?rev=254496#L489 - https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp?rev=254496#L653
Attachments
patch to remove cairoOperator from copyRectFromOneSurfaceToAnother (6.47 KB, patch)
2020-01-13 23:20 PST, Tomoki Imai 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tomoki Imai
Comment 1 2020-01-13 23:20:39 PST
Created attachment 387624 [details] patch to remove cairoOperator from copyRectFromOneSurfaceToAnother
WebKit Commit Bot
Comment 2 2020-01-14 02:01:14 PST
Comment on attachment 387624 [details] patch to remove cairoOperator from copyRectFromOneSurfaceToAnother Clearing flags on attachment: 387624 Committed r254502: <https://trac.webkit.org/changeset/254502>
WebKit Commit Bot
Comment 3 2020-01-14 02:01:15 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2020-01-14 02:02:15 PST
<rdar://problem/58562059>
Tomoki Imai
Comment 5 2020-01-14 17:53:50 PST
Thanks for your reviews!
Note You need to log in before you can comment on or make changes to this bug.