| Summary: | [JSC] Put JSProxy in IsoSubspace | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | annulen, ews-watchlist, gyuyoung.kim, keith_miller, mark.lam, msaboff, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Yusuke Suzuki
2020-01-13 12:23:12 PST
Created attachment 387556 [details]
Patch
Created attachment 387558 [details]
Patch
Created attachment 387559 [details]
Patch
Comment on attachment 387558 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387558&action=review r=me > Source/JavaScriptCore/runtime/JSStringIterator.h:28 > -#include "JSObject.h" > +#include "JSInternalFieldObjectImpl.h" Seems unrelated. Is this needed for a build fix? If not, can you land this separately? rs=me for that patch if needed. Comment on attachment 387559 [details] Patch r=me with comment from https://bugs.webkit.org/show_bug.cgi?id=206187#c4 Comment on attachment 387558 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387558&action=review >> Source/JavaScriptCore/runtime/JSStringIterator.h:28 >> +#include "JSInternalFieldObjectImpl.h" > > Seems unrelated. Is this needed for a build fix? If not, can you land this separately? rs=me for that patch if needed. Yes, this is required to fix the build. This patch removes a file, changing unified builds combination and breaking it. Committed r254447: <https://trac.webkit.org/changeset/254447> |