Bug 206187

Summary: [JSC] Put JSProxy in IsoSubspace
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, ews-watchlist, gyuyoung.kim, keith_miller, mark.lam, msaboff, ryuan.choi, sbarati, sergio, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
mark.lam: review+
Patch mark.lam: review+

Description Yusuke Suzuki 2020-01-13 12:23:12 PST
[JSC] Put JSProxy in IsoSubspace
Comment 1 Yusuke Suzuki 2020-01-13 12:24:55 PST
Created attachment 387556 [details]
Patch
Comment 2 Yusuke Suzuki 2020-01-13 12:33:06 PST
Created attachment 387558 [details]
Patch
Comment 3 Yusuke Suzuki 2020-01-13 12:35:35 PST
Created attachment 387559 [details]
Patch
Comment 4 Mark Lam 2020-01-13 12:46:23 PST
Comment on attachment 387558 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387558&action=review

r=me

> Source/JavaScriptCore/runtime/JSStringIterator.h:28
> -#include "JSObject.h"
> +#include "JSInternalFieldObjectImpl.h"

Seems unrelated.  Is this needed for a build fix?  If not, can you land this separately?  rs=me for that patch if needed.
Comment 5 Mark Lam 2020-01-13 12:47:45 PST
Comment on attachment 387559 [details]
Patch

r=me with comment from https://bugs.webkit.org/show_bug.cgi?id=206187#c4
Comment 6 Yusuke Suzuki 2020-01-13 12:55:52 PST
Comment on attachment 387558 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387558&action=review

>> Source/JavaScriptCore/runtime/JSStringIterator.h:28
>> +#include "JSInternalFieldObjectImpl.h"
> 
> Seems unrelated.  Is this needed for a build fix?  If not, can you land this separately?  rs=me for that patch if needed.

Yes, this is required to fix the build. This patch removes a file, changing unified builds combination and breaking it.
Comment 7 Yusuke Suzuki 2020-01-13 13:28:50 PST
Committed r254447: <https://trac.webkit.org/changeset/254447>
Comment 8 Radar WebKit Bug Importer 2020-01-13 13:29:16 PST
<rdar://problem/58541273>