Bug 206187

Summary: [JSC] Put JSProxy in IsoSubspace
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, ews-watchlist, gyuyoung.kim, keith_miller, mark.lam, msaboff, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
mark.lam: review+
Patch mark.lam: review+

Yusuke Suzuki
Reported 2020-01-13 12:23:12 PST
[JSC] Put JSProxy in IsoSubspace
Attachments
Patch (16.97 KB, patch)
2020-01-13 12:24 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (17.44 KB, patch)
2020-01-13 12:33 PST, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
Patch (17.66 KB, patch)
2020-01-13 12:35 PST, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2020-01-13 12:24:55 PST
Created attachment 387556 [details] Patch
Yusuke Suzuki
Comment 2 2020-01-13 12:33:06 PST
Created attachment 387558 [details] Patch
Yusuke Suzuki
Comment 3 2020-01-13 12:35:35 PST
Created attachment 387559 [details] Patch
Mark Lam
Comment 4 2020-01-13 12:46:23 PST
Comment on attachment 387558 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387558&action=review r=me > Source/JavaScriptCore/runtime/JSStringIterator.h:28 > -#include "JSObject.h" > +#include "JSInternalFieldObjectImpl.h" Seems unrelated. Is this needed for a build fix? If not, can you land this separately? rs=me for that patch if needed.
Mark Lam
Comment 5 2020-01-13 12:47:45 PST
Comment on attachment 387559 [details] Patch r=me with comment from https://bugs.webkit.org/show_bug.cgi?id=206187#c4
Yusuke Suzuki
Comment 6 2020-01-13 12:55:52 PST
Comment on attachment 387558 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387558&action=review >> Source/JavaScriptCore/runtime/JSStringIterator.h:28 >> +#include "JSInternalFieldObjectImpl.h" > > Seems unrelated. Is this needed for a build fix? If not, can you land this separately? rs=me for that patch if needed. Yes, this is required to fix the build. This patch removes a file, changing unified builds combination and breaking it.
Yusuke Suzuki
Comment 7 2020-01-13 13:28:50 PST
Committed r254447: <https://trac.webkit.org/changeset/254447>
Radar WebKit Bug Importer
Comment 8 2020-01-13 13:29:16 PST
<rdar://problem/58541273>
Note You need to log in before you can comment on or make changes to this bug.