Bug 20613

Summary: Can't add a keyframe rule via the DOM
Product: WebKit Reporter: Dean Jackson <dino>
Component: CSSAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 20594    
Attachments:
Description Flags
patch for keyframes via dom
none
updated patch mitz: review+

Dean Jackson
Reported 2008-09-02 17:28:53 PDT
I forgot to add the back-door keyframe parsing to the CSS grammar, which means programmatically added keyframe rules don't work. See LayoutTests/css3/keyframes-rule.html
Attachments
patch for keyframes via dom (4.66 KB, patch)
2008-09-05 19:40 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
updated patch (4.72 KB, patch)
2008-09-08 15:10 PDT, Dean Jackson 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2008-09-05 19:40:43 PDT
Created attachment 23209 [details] patch for keyframes via dom Updated test too. Note that keyframes rules are sorted.
Dean Jackson
Comment 2 2008-09-05 19:41:18 PDT
This will fix the failing LayoutTest
Dean Jackson
Comment 3 2008-09-08 15:10:11 PDT
Created attachment 23275 [details] updated patch i'd left a line out
mitz
Comment 4 2008-09-08 17:29:33 PDT
Comment on attachment 23275 [details] updated patch r=me
Dean Jackson
Comment 5 2008-09-08 18:04:17 PDT
Committed r36278 M WebCore/ChangeLog M WebCore/css/CSSGrammar.y M WebCore/css/tokenizer.flex M LayoutTests/ChangeLog M LayoutTests/css3/keyframes-rule-expected.txt M LayoutTests/css3/keyframes-rule.html
Note You need to log in before you can comment on or make changes to this bug.