| Summary: | [iOS] Remove 'com.apple.diagnosticd' from WebContent process sandbox | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
| Component: | WebKit2 | Assignee: | Brent Fulgham <bfulgham> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, bfulgham, pvollan, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=206115 | ||||||
| Bug Depends on: | 205292 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Brent Fulgham
2020-01-10 17:15:49 PST
Created attachment 387404 [details]
Patch
Comment on attachment 387404 [details]
Patch
Tests pass on device.
Comment on attachment 387404 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387404&action=review > LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html:18 > + shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.diagnosticd\")"); I expected this to be true, since we always issue the extension for internal builds, but perhaps I am mistaken? Comment on attachment 387404 [details]
Patch
R=me. Perhaps you could consider removing the test, since I expect there to always be access to diagnostics in internal builds, because an extension is issued in this case.
(In reply to Per Arne Vollan from comment #5) > Comment on attachment 387404 [details] > Patch > > R=me. Perhaps you could consider removing the test, since I expect there to > always be access to diagnostics in internal builds, because an extension is > issued in this case. Yes -- you are right. We can't write a test that will work in Open Source and Internal environments. Committed r254436: <https://trac.webkit.org/changeset/254436> |