| Summary: | Reformat FrameView logging | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Rollin <krollin> | ||||
| Component: | WebKit Misc. | Assignee: | Keith Rollin <krollin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, cdumez, commit-queue, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=205679 | ||||||
| Attachments: |
|
||||||
Created attachment 387184 [details]
Patch
Comment on attachment 387184 [details]
Patch
r=me. The Mac-wk2 failures seem totally unrelated (and perhaps an error in the EWS system itself).
Comment on attachment 387184 [details] Patch Clearing flags on attachment: 387184 Committed r254267: <https://trac.webkit.org/changeset/254267> All reviewed patches have been landed. Closing bug. |
Update the format used by FrameView in its RELEASE_LOG logging. Use the format used by WebPageProxy and NetworkResourceLoader, which is generally of the form: <object-address> - [<values that help thread together operations>] <class>::<method>: <message and other useful values> So, for example: 0x4a1cf8010 - FrameView::fireLayoutRelatedMilestonesIfNeeded() - firing first visually non-empty layout milestone on the main frame becomes: 0x561be8010 - [frame=0x55d47e000, main=1] FrameView::fireLayoutRelatedMilestonesIfNeeded: Firing first visually non-empty layout milestone on the main frame