Bug 20590

Summary: FTB on GTK+ :undefined reference to `KJS::SmallStrings::SmallStrings()'
Product: WebKit Reporter: Stéphane Marguet <stempubuntu>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: zwarich
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
URL: http://launchpadlibrarian.net/17207250/buildlog_ubuntu-hardy-i386.webkit_1.0.1-2%2Br36009~hardyppa1_FAILEDTOBUILD.txt.gz
Attachments:
Description Flags
Fix build failure when ENABLE_DEBUG is not set none

Stéphane Marguet
Reported 2008-09-01 07:54:56 PDT
Fail to build on GTK, in JavaScriptCore undefined reference to `KJS::SmallStrings::SmallStrings()'
Attachments
Fix build failure when ENABLE_DEBUG is not set (724 bytes, patch)
2008-09-01 13:05 PDT, Pierre Riteau 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Landry Breuil
Comment 1 2008-09-01 08:53:01 PDT
I can confirm it on OpenBSD with r36009. For me, r36006 should have added SmallString.cpp to javascriptcore_sources (in JavaScriptCore/GNUmakefile.am) unconditionally, not only if ENABLE_DEBUG is set.
Pierre Riteau
Comment 2 2008-09-01 13:05:24 PDT
Created attachment 23102 [details] Fix build failure when ENABLE_DEBUG is not set
Pierre Riteau
Comment 3 2008-09-01 13:07:38 PDT
Comment on attachment 23102 [details] Fix build failure when ENABLE_DEBUG is not set Patch from Landry Breuil. Fixes build failure on OpenBSD/r36009.
Cameron Zwarich (cpst)
Comment 4 2008-09-01 20:16:01 PDT
Wasn't this fixed by r36018? http://trac.webkit.org/changeset/36018
Stéphane Marguet
Comment 5 2008-09-03 03:19:15 PDT
r36053 succesfully built, so it look like r36018 fixed this bug.
Note You need to log in before you can comment on or make changes to this bug.