Summary: | [WebAuthn] Report CTAP Client Pin Error to clients | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> | ||||||
Component: | WebKit Misc. | Assignee: | Jiewen Tan <jiewen_tan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, jiewen_tan, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 181943 | ||||||||
Attachments: |
|
Description
Jiewen Tan
2020-01-06 15:35:20 PST
Created attachment 390014 [details]
Patch
Comment on attachment 390014 [details]
Patch
r=me
Comment on attachment 390014 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390014&action=review > Source/WebKit/ChangeLog:12 > + All error needs to report back to client to show appropriate UI to guide users for the next step. Maybe, "All errors should be reported to the client so that appropriate UI can be displayed to users." Comment on attachment 390014 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390014&action=review Thanks Brent for r+ this patch. >> Source/WebKit/ChangeLog:12 >> + All error needs to report back to client to show appropriate UI to guide users for the next step. > > Maybe, "All errors should be reported to the client so that appropriate UI can be displayed to users." Fixed. Created attachment 390117 [details]
Patch for landing
Comment on attachment 390117 [details] Patch for landing Clearing flags on attachment: 390117 Committed r256062: <https://trac.webkit.org/changeset/256062> |