Bug 205837

Summary: [WebAuthn] Report CTAP Client Pin Error to clients
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebKit Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 181943    
Attachments:
Description Flags
Patch
bfulgham: review+
Patch for landing none

Description Jiewen Tan 2020-01-06 15:35:20 PST
Report CTAP Client Pin Error to clients.
Comment 1 Radar WebKit Bug Importer 2020-01-06 15:35:51 PST
<rdar://problem/58356872>
Comment 2 Jiewen Tan 2020-02-06 15:31:01 PST
Created attachment 390014 [details]
Patch
Comment 3 Brent Fulgham 2020-02-07 12:54:44 PST
Comment on attachment 390014 [details]
Patch

r=me
Comment 4 Brent Fulgham 2020-02-07 12:59:43 PST
Comment on attachment 390014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390014&action=review

> Source/WebKit/ChangeLog:12
> +        All error needs to report back to client to show appropriate UI to guide users for the next step.

Maybe, "All errors should be reported to the client so that appropriate UI can be displayed to users."
Comment 5 Jiewen Tan 2020-02-07 13:05:48 PST
Comment on attachment 390014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390014&action=review

Thanks Brent for r+ this patch.

>> Source/WebKit/ChangeLog:12
>> +        All error needs to report back to client to show appropriate UI to guide users for the next step.
> 
> Maybe, "All errors should be reported to the client so that appropriate UI can be displayed to users."

Fixed.
Comment 6 Jiewen Tan 2020-02-07 13:07:45 PST
Created attachment 390117 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2020-02-07 14:16:58 PST
Comment on attachment 390117 [details]
Patch for landing

Clearing flags on attachment: 390117

Committed r256062: <https://trac.webkit.org/changeset/256062>