Bug 205807 – REGRESSION: [ Mac Debug ] inspector/page/setBootstrapScript-main-frame.html is a flaky failure

• Component: Web Inspector
• Status: RESOLVED FIXED

[Truitt Savell]

inspector/page/setBootstrapScript-main-frame.html

Description:
This test is a flaky failure on Mac Debug. This test has been flakey for at least several months. I do not have a starting point at this time. It was first added in https://trac.webkit.org/changeset/251531/webkit so this test may have been flaky from introduction.

History:
https://results.webkit.org/?suite=layout-tests&test=inspector%2Fpage%2FsetBootstrapScript-main-frame.html&limit=10000

Diff:
--- /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/inspector/page/setBootstrapScript-main-frame-expected.txt
+++ /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/inspector/page/setBootstrapScript-main-frame-actual.txt
@@ -6,5 +6,7 @@
 PASS: 'valueFromBootstrapScript' should be 'undefined'.
 Setting bootstrap script...
 Reloading page...
-PASS: 'valueFromBootstrapScript' should be '42'.
+FAIL: 'valueFromBootstrapScript' should be '42'.
+    Expected: 42
+    Actual: undefined

[Radar WebKit Bug Importer]

<rdar://problem/58344669>

[Truitt Savell]

marked test as failing while it is investigated: https://trac.webkit.org/changeset/254059/webkit

[Devin Rousso]

Created attachment 386906 [details]
Patch

It took a while (over 10000 iterations), but I was finally able to reproduce this locally.  I'm not 100% sure whether all of them are actually necessary to fix this issue, but I do think all of them are necessary overall (e.g. some may effectively be a drive-by), and since it seems to reproduce so infrequently for me, I'd rather put the patch up and get it tested/landed than take the (likely long) time to try to bisect what actually fixed it among these changes.

[Dean Jackson]

Comment on attachment 386906 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386906&action=review

> Source/WebInspectorUI/UserInterface/Controllers/NetworkManager.js:1432
> +        let source = this._bootstrapScript.content || "";

Use ?? ? (wouldn't matter here though).

Also, this can be const.

[Devin Rousso]

Comment on attachment 386906 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386906&action=review

>> Source/WebInspectorUI/UserInterface/Controllers/NetworkManager.js:1432
>> +        let source = this._bootstrapScript.content || "";
> 
> Use ?? ? (wouldn't matter here though).
> 
> Also, this can be const.

In this case, I'd prefer `||` as I would also want to switch to a string in the case that `this._bootstrapScript.content` was actually `false`.  Frankly, this code is probably unnecessary, but it can't hurt ¯\_(ツ)_/¯

Web Inspector style is to only use `const` for values that don't change between sessions, like literal constant values.

[WebKit Commit Bot]

Comment on attachment 386906 [details]
Patch

Rejecting attachment 386906 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 386906, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=386906&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=205807&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 386906 from bug 205807.
Fetching: https://bugs.webkit.org/attachment.cgi?id=386906
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Dean Jackson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 5 diffs from patch file(s).
patching file Source/WebInspectorUI/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebInspectorUI/UserInterface/Controllers/NetworkManager.js
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/inspector/page/setBootstrapScript-main-frame.html
patching file LayoutTests/platform/mac/TestExpectations
Hunk #1 FAILED at 1967.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/TestExpectations.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Dean Jackson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/13300740

[Devin Rousso]

Created attachment 387000 [details]
Patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 387000 [details]:

imported/w3c/web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/content/002.xhtml bug 205881 (author: [e-mail])
transitions/default-timing-function.html bug 138901 (authors: [e-mail] and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 387000 [details]
Patch

Clearing flags on attachment: 387000

Committed r254145: <https://trac.webkit.org/changeset/254145>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.