Bug 205799

Summary:

The initial value of color-scheme is 'normal', not 'auto'

Product:

WebKit

Reporter:

Rune Lillesveen <rune.lillesveen>

Component:

CSS

Assignee:

Tim Nguyen (:ntim) <ntim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

akeerthi, changseok, darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jh718.park, joepeck, koivisto, kondapallykalyan, macpherson, menard, ntim, pdr, rniwa, simon.fraser, thorton, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Safari Technology Preview

Hardware:

Mac

OS:

macOS 10.14

Attachments:

Description	Flags
To check layout test result	none
To check layout test result	ews-feeder: commit-queue-

Description Rune Lillesveen 2020-01-06 06:39:49 PST

The initial value of color-scheme was resolved to be 'normal' instead of 'auto' in [1].

This causes many failures in https://wpt.fyi/results/css/css-color-adjust

[1] https://github.com/w3c/csswg-drafts/issues/3849

Comment 1 Radar WebKit Bug Importer 2020-01-07 14:39:30 PST

<rdar://problem/58388530>

Comment 2 Joonghun Park 2021-09-23 09:52:00 PDT

Created attachment 439054 [details]
To check layout test result

Comment 3 Joonghun Park 2021-09-23 11:05:50 PDT

Created attachment 439070 [details]
To check layout test result

Comment 4 Aditya Keerthi 2021-09-23 12:12:07 PDT

Comment on attachment 439070 [details]
To check layout test result

View in context: https://bugs.webkit.org/attachment.cgi?id=439070&action=review

> Source/WebCore/css/parser/CSSPropertyParser.cpp:3967
>              // Auto is only allowed as a single value, and was handled earlier.

This comment needs to be updated.

Comment 5 Joonghun Park 2021-09-23 15:37:43 PDT

Comment on attachment 439070 [details]
To check layout test result

View in context: https://bugs.webkit.org/attachment.cgi?id=439070&action=review

>> Source/WebCore/css/parser/CSSPropertyParser.cpp:3967
>>              // Auto is only allowed as a single value, and was handled earlier.
> 
> This comment needs to be updated.

Ok, I will change this in the next patchset.

Comment 6 Timothy Hatcher 2021-09-23 15:51:35 PDT

Mail and Safari, which looks for "auto" in some dark mode detection scripts, will need updated after this change lands.

See bug 224810.

Comment 7 Joonghun Park 2021-09-23 17:25:14 PDT

(In reply to Timothy Hatcher from comment #6)
> Mail and Safari, which looks for "auto" in some dark mode detection scripts,
> will need updated after this change lands.
> 
> See bug 224810.

It seems that this bug is duplicated with 224810. Then I will mark this bug as duplicated.

Comment 8 Joonghun Park 2021-09-23 17:26:42 PDT


*** This bug has been marked as a duplicate of bug 224810 ***

Comment 9 Darin Adler 2021-09-28 12:19:25 PDT

(In reply to Timothy Hatcher from comment #6)
> Mail and Safari, which looks for "auto" in some dark mode detection scripts,
> will need updated after this change lands.

Can we instead update them beforehand to work with both "auto" and "normal"?

Comment 10 Tim Nguyen (:ntim) 2022-08-18 21:04:03 PDT

Unduping, I think this is worth doing separately.

Comment 11 Tim Nguyen (:ntim) 2022-08-18 21:59:17 PDT

Pull request: https://github.com/WebKit/WebKit/pull/3471

Comment 12 EWS 2022-08-22 15:09:34 PDT

Committed 253659@main (1ec4bb7857c4): <https://commits.webkit.org/253659@main>

Reviewed commits have been landed. Closing PR #3471 and removing active labels.