Bug 205778

Summary: Rename GraphicsContext3D to GraphicsContextGL
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, calvaris, cdumez, cgarcia, cmarcelo, commit-queue, dbates, don.olmstead, eric.carlson, esprehn+autocc, ews-watchlist, glenn, graouts, gustavo, gyuyoung.kim, hi, japhet, jbedard, jer.noble, joepeck, kondapallykalyan, luiz, menard, mmaxfield, noam, philipj, pnormand, rniwa, ross.kirsling, ryuan.choi, sam, sergio, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
sam: review+
EWS test
none
EWS test
none
EWS test
none
Build fix none

Dean Jackson
Reported 2020-01-05 12:42:40 PST
Rename GraphicsContext3D to GraphicsContextGL
Attachments
Patch (1.66 MB, patch)
2020-01-05 13:41 PST, Dean Jackson 		sam: review+
DetailsFormatted DiffDiff
EWS test (1.66 MB, patch)
2020-01-05 20:09 PST, Dean Jackson 		no flags
DetailsFormatted DiffDiff
EWS test (1.66 MB, patch)
2020-01-06 09:36 PST, Dean Jackson 		no flags
DetailsFormatted DiffDiff
EWS test (1.66 MB, patch)
2020-01-06 09:53 PST, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Build fix (14.22 KB, patch)
2020-01-06 16:10 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2020-01-05 13:41:07 PST
Created attachment 386797 [details] Patch
Radar WebKit Bug Importer
Comment 2 2020-01-05 13:41:28 PST
<rdar://problem/58327597>
Sam Weinig
Comment 3 2020-01-05 15:21:34 PST
Comment on attachment 386797 [details] Patch rs=me, but get it building first.
Dean Jackson
Comment 4 2020-01-05 20:09:46 PST
Created attachment 386806 [details] EWS test
Dean Jackson
Comment 5 2020-01-06 09:36:18 PST
Created attachment 386854 [details] EWS test
Dean Jackson
Comment 6 2020-01-06 09:53:37 PST
Created attachment 386856 [details] EWS test
Dean Jackson
Comment 7 2020-01-06 11:15:21 PST
Committed r254064: <https://trac.webkit.org/changeset/254064>
Don Olmstead
Comment 8 2020-01-06 15:59:06 PST
Reopening to land build fix
Don Olmstead
Comment 9 2020-01-06 16:10:12 PST
Created attachment 386908 [details] Build fix
Don Olmstead
Comment 10 2020-01-06 16:43:42 PST Comment hidden (obsolete)
Don Olmstead
Comment 11 2020-01-06 16:43:48 PST Comment hidden (obsolete)
Don Olmstead
Comment 12 2020-01-06 16:44:13 PST
Comment on attachment 386908 [details] Build fix Mac and GTK seem happy. Asking for a review since I modified Platform.h and added USE_ macros.
WebKit Commit Bot
Comment 13 2020-01-06 18:52:34 PST
Comment on attachment 386908 [details] Build fix Clearing flags on attachment: 386908 Committed r254103: <https://trac.webkit.org/changeset/254103>
Don Olmstead
Comment 14 2020-01-06 21:54:00 PST
Build is back to green
Note You need to log in before you can comment on or make changes to this bug.