Bug 205778

Summary: Rename GraphicsContext3D to GraphicsContextGL
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, calvaris, cdumez, cgarcia, cmarcelo, commit-queue, dbates, don.olmstead, eric.carlson, esprehn+autocc, ews-watchlist, glenn, graouts, gustavo, gyuyoung.kim, hi, japhet, jbedard, jer.noble, joepeck, kondapallykalyan, luiz, menard, mmaxfield, noam, philipj, pnormand, rniwa, ross.kirsling, ryuan.choi, sam, sergio, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
sam: review+
EWS test
none
EWS test
none
EWS test
none
Build fix none

Description Dean Jackson 2020-01-05 12:42:40 PST 
Rename GraphicsContext3D to GraphicsContextGL
Comment 1 Dean Jackson 2020-01-05 13:41:07 PST 
Created attachment 386797 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-01-05 13:41:28 PST 
<rdar://problem/58327597>
Comment 3 Sam Weinig 2020-01-05 15:21:34 PST 
Comment on attachment 386797 [details]
Patch

rs=me, but get it building first.
Comment 4 Dean Jackson 2020-01-05 20:09:46 PST 
Created attachment 386806 [details]
EWS test
Comment 5 Dean Jackson 2020-01-06 09:36:18 PST 
Created attachment 386854 [details]
EWS test
Comment 6 Dean Jackson 2020-01-06 09:53:37 PST 
Created attachment 386856 [details]
EWS test
Comment 7 Dean Jackson 2020-01-06 11:15:21 PST 
Committed r254064: <https://trac.webkit.org/changeset/254064>
Comment 8 Don Olmstead 2020-01-06 15:59:06 PST 
Reopening to land build fix
Comment 9 Don Olmstead 2020-01-06 16:10:12 PST 
Created attachment 386908 [details]
Build fix
Comment 10 Don Olmstead 2020-01-06 16:43:42 PST Comment hidden (obsolete)
Comment 11 Don Olmstead 2020-01-06 16:43:48 PST Comment hidden (obsolete)
Comment 12 Don Olmstead 2020-01-06 16:44:13 PST 
Comment on attachment 386908 [details]
Build fix

Mac and GTK seem happy. Asking for a review since I modified Platform.h and added USE_ macros.
Comment 13 WebKit Commit Bot 2020-01-06 18:52:34 PST 
Comment on attachment 386908 [details]
Build fix

Clearing flags on attachment: 386908

Committed r254103: <https://trac.webkit.org/changeset/254103>
Comment 14 Don Olmstead 2020-01-06 21:54:00 PST 
Build is back to green