Bug 205766

Summary: [WPE][Qt] TestRunJavaScript failure
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WPE WebKitAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch cgarcia: review+

Philippe Normand
Reported 2020-01-04 10:02:54 PST
********* Start testing of TestRunJavaScript ********* Config: Using QtTest library 5.14.0, Qt 5.14.0 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 9.2.0) PASS : TestRunJavaScript::initTestCase() FAIL! : TestRunJavaScript::run() '!callback.isUndefined()' returned FALSE. () Loc: [../../Tools/TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp(42)] PASS : TestRunJavaScript::cleanupTestCase() Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted, 1116ms ********* Finished testing of TestRunJavaScript ********* Unexpected failures (1) /app/webkit/WebKitBuild/Release/bin/TestWebKitAPI/WPEQt/TestRunJavaScript TestRunJavaScript
Attachments
Patch (1.60 KB, patch)
2020-01-04 10:06 PST, Philippe Normand 		cgarcia: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2020-01-04 10:04:42 PST
I mean: ********* Start testing of TestRunJavaScript ********* Config: Using QtTest library 5.14.0, Qt 5.14.0 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 9.2.0) PASS : TestRunJavaScript::initTestCase() QWARN : TestRunJavaScript::run() Warning: Using function expressions as statements in scripts is not compliant with the ECMAScript specification: "function(result) { Qt.tst_data = result; }..." This will throw a syntax error in Qt 5.12. If you want a function expression, surround it by parentheses. FAIL! : TestRunJavaScript::run() '!callback.isError()' returned FALSE. (SyntaxError: Unexpected token `(') Loc: [../../Tools/TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp(41)] PASS : TestRunJavaScript::cleanupTestCase() Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted, 1061ms ********* Finished testing of TestRunJavaScript ********* Unexpected failures (1) /app/webkit/WebKitBuild/Release/bin/TestWebKitAPI/WPEQt/TestRunJavaScript TestRunJavaScript
Philippe Normand
Comment 2 2020-01-04 10:06:40 PST
Created attachment 386765 [details] Patch
Philippe Normand
Comment 3 2020-01-06 01:13:03 PST
Committed r254049: <https://trac.webkit.org/changeset/254049>
Note You need to log in before you can comment on or make changes to this bug.